chore: add comments to exports in user impl module #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilslice
commented
Sep 3, 2024
| jsonWrappedRustType, | ||
| capitalize, | ||
| camelToSnakeCase | ||
| camelToSnakeCase, |
zshipko
approved these changes
Sep 3, 2024
zshipko
left a comment
zshipko
left a comment
There was a problem hiding this comment.
Looks good! I agree that leaving the full path to types is fine for now - in the case of serde_json::Value it might be more helpful to know Value type is coming from serde_json without having to check (although checking isn't so hard either)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially completes #2
After looking at it more, I think the paths are way simpler to leave in the types, and not that hard for the end-user to remove & add a
usethemselves. There's a few different contexts in which this bindgen would need to check if ausestatement is needed, and it's a bit complex to abstract, and alternatively super verbose to check around all the edges.