Skip to content

Mss/13133 destination column concatenation #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 17, 2023
Merged

Mss/13133 destination column concatenation #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7e462b7
Added logic for concatenation of destination columns.
MatthiasSort Apr 26, 2023
8a1351b
added Trim in Conditionals on In and NotIn.
MatthiasSort May 15, 2023
813ef6e
fixed Obsolete function calls.
MatthiasSort May 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/MappingExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ public static string GetConditionalSql(string conditionalsSql, string columnName
{
if (mappingConditional.SourceColumn.Type == typeof(string))
{
conditionalValue = string.Join(",", conditionalValue.Split(new string[] { "," }, StringSplitOptions.RemoveEmptyEntries).Select(val => $"'{val}'"));
conditionalValue = string.Join(",", conditionalValue.Split(new string[] { "," }, StringSplitOptions.RemoveEmptyEntries).Select(val => $"'{val.Trim()}'"));
}
conditionalsSql = string.Format(
"{0}[{1}] IN ({2}) and ",
Expand All @@ -164,7 +164,7 @@ public static string GetConditionalSql(string conditionalsSql, string columnName
{
if (mappingConditional.SourceColumn.Type == typeof(string))
{
notInConditionalValue = string.Join(",", notInConditionalValue.Split(new string[] { "," }, StringSplitOptions.RemoveEmptyEntries).Select(val => $"'{val}'"));
notInConditionalValue = string.Join(",", notInConditionalValue.Split(new string[] { "," }, StringSplitOptions.RemoveEmptyEntries).Select(val => $"'{val.Trim()}'"));
}
conditionalsSql = string.Format(
"{0}[{1}] NOT IN ({2}) and ",
Expand Down
28 changes: 10 additions & 18 deletions src/SQLDestinationWriter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ protected virtual void Initialize()
{
List<SqlColumn> destColumns = new List<SqlColumn>();
var columnMappings = Mapping.GetColumnMappings();
foreach (ColumnMapping columnMapping in columnMappings)
foreach (ColumnMapping columnMapping in columnMappings.DistinctBy(obj => obj.DestinationColumn.Name))
{
destColumns.Add((SqlColumn)columnMapping.DestinationColumn);
}
Expand Down Expand Up @@ -200,23 +200,15 @@ public virtual void Write(Dictionary<string, object> row)
{
if (columnMapping.HasScriptWithValue || row.ContainsKey(columnMapping.SourceColumn.Name))
{
switch (columnMapping.ScriptType)
object dataToRow = columnMapping.ConvertInputValueToOutputValue(row[columnMapping.SourceColumn.Name]);

if (columnMappings.Any(obj => obj.DestinationColumn.Name == columnMapping.DestinationColumn.Name && obj.GetId() != columnMapping.GetId()))
{
dataRow[columnMapping.DestinationColumn.Name] += dataToRow.ToString();
}
else
{
case ScriptType.None:
dataRow[columnMapping.DestinationColumn.Name] = columnMapping.ConvertInputToOutputFormat(row[columnMapping.SourceColumn.Name]);
break;
case ScriptType.Append:
dataRow[columnMapping.DestinationColumn.Name] = columnMapping.ConvertInputToOutputFormat(row[columnMapping.SourceColumn.Name]) + columnMapping.ScriptValue;
break;
case ScriptType.Prepend:
dataRow[columnMapping.DestinationColumn.Name] = columnMapping.ScriptValue + columnMapping.ConvertInputToOutputFormat(row[columnMapping.SourceColumn.Name]);
break;
case ScriptType.Constant:
dataRow[columnMapping.DestinationColumn.Name] = columnMapping.GetScriptValue();
break;
case ScriptType.NewGuid:
dataRow[columnMapping.DestinationColumn.Name] = columnMapping.GetScriptValue();
break;
dataRow[columnMapping.DestinationColumn.Name] = dataToRow;
}
}
else
Expand Down Expand Up @@ -425,7 +417,7 @@ public virtual void MoveDataToMainTable(SqlTransaction sqlTransaction, bool upda
{
string sqlConditions = "";
string firstKey = "";
var columnMappings = Mapping.GetColumnMappings().Where(cm => cm.Active);
var columnMappings = Mapping.GetColumnMappings().Where(cm => cm.Active).DistinctBy(obj => obj.DestinationColumn.Name);
bool isPrimaryKeyColumnExists = columnMappings.IsKeyColumnExists();

foreach (ColumnMapping columnMapping in columnMappings)
Expand Down