Enhancement: Refactoring API folder code #283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZibanPirate
force-pushed
the
feat/cleaner-api
branch
from
757217d to
9d3038a
Compare
ZibanPirate
changed the title
ZibanPirate
force-pushed
the
feat/cleaner-api
branch
from
8c28fed to
e057043
Compare
ZibanPirate
force-pushed
the
feat/cleaner-api
branch
from
7c092c6 to
debbe8a
Compare
ZibanPirate
force-pushed
the
feat/cleaner-api
branch
from
bc5f789 to
989ee7f
Compare
Member
Author
|
@well-balanced this PR will make it a lot easier to contribute to api folder now |
ZibanPirate
force-pushed
the
feat/cleaner-api
branch
from
224ee43 to
1a2b2cb
Compare
abderrahmaneMustapha
approved these changes
Apr 8, 2021
Contributor
|
@ZibanPirate thx :) I'll work on this weekend 😄 |
Contributor
|
@ZibanPirate Hi Ziban! I'd like to get some feedback to see if my code is going well. could you check code and questions? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
API code cleanup branch, resolves #277
This PR introduces dependency injection to api folder, the old api endpoints are still functioning, and the new endpoints are now under /v2 route.
Tasks
typedias a DI tool for services (ea3fbc5 & 9bc41c3)routing-controllers(52d9682 & 55163a8)/v2and update frontend accordingly Migrating old endpoints to v2 API #286api/Readme.mdto explain code structure insideapifolder (44ec2d0)The unfinished tasks will be converted into issue tickets so everyone can contribute
Type of change