Skip to content

Migrate the old '/Contributors' endpoint to v2 #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 10, 2021
Merged

Migrate the old '/Contributors' endpoint to v2 #289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4d7351d
Remove the old 'Contributors' api
well-balanced Apr 10, 2021
3773af2
Update web/src/apps/main/redux/actions/articles-page/index.ts
well-balanced Apr 10, 2021
c1bfe11
Update web/src/apps/main/redux/actions/documentation-page/index.ts
well-balanced Apr 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 0 additions & 40 deletions api/src/app/controllers/contributors/index.ts
View file
Open in desktop

This file was deleted.

9 changes: 0 additions & 9 deletions api/src/app/routes/api/contributors/index.ts
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions api/src/app/routes/api/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,11 @@
import express, { Router } from "express";

import contributors from "./contributors";
import { getRoot } from "../../controllers/etc";
import github from "./github";

const router: Router = express.Router();

router.get("/", getRoot);
router.use("/github", github);
router.use("/contributors", contributors);

export default router;
2 changes: 1 addition & 1 deletion web/src/apps/main/redux/actions/articles-page/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ export const fetchCurrentArticleContributors = (): ThunkResult<
if (!currentArticle || Array.isArray(currentArticle.contributors)) return;

const response = await Axios.get<GithubUser[]>(
apiURL + `/contributors?articleSlug=${currentArticle.slug}`,
apiURL + `/v2/contributors?path=articles/${currentArticle.slug}`,
);

if (response.data.hasOwnProperty("error")) {
Expand Down
2 changes: 1 addition & 1 deletion web/src/apps/main/redux/actions/documentation-page/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ const fetchCurrentDocumentContributors = (): ThunkResult<
if (!currentDocument || Array.isArray(currentDocument.contributors)) return;

const response = await Axios.get<GithubUser[]>(
apiURL + `/contributors?documentSlug=${currentDocument.slug}`,
apiURL + `/v2/contributors?path=documentation/${currentDocument.slug}`,
);

if (response.data.hasOwnProperty("error")) {
Expand Down