Skip to content

Conversation

@ZibanPirate
Copy link
Member

@ZibanPirate ZibanPirate commented Apr 11, 2021

Description

after merging #290 and #289 , the app was crashing because of changes in api response, this PR will fix the problem and prevent such bug in the future.

fixes #291

also fixes #284

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

@ZibanPirate ZibanPirate self-assigned this Apr 11, 2021
@github-actions github-actions bot added api API related changes ( api folder ) common Common related changes ( common folder ) web Web related changes ( web folder ) labels Apr 11, 2021
@ZibanPirate ZibanPirate requested a review from a team April 11, 2021 16:34
@ZibanPirate ZibanPirate marked this pull request as draft April 11, 2021 17:18
@ZibanPirate ZibanPirate force-pushed the fix/refactor-api-response-to-common branch from 9540b88 to c6726ab Compare April 11, 2021 19:19
@ZibanPirate ZibanPirate force-pushed the fix/refactor-api-response-to-common branch from c6726ab to 2ed499f Compare April 11, 2021 19:41
@ZibanPirate ZibanPirate marked this pull request as ready for review April 11, 2021 19:49
@ZibanPirate ZibanPirate merged commit 5e093a8 into main Apr 11, 2021
@ZibanPirate ZibanPirate deleted the fix/refactor-api-response-to-common branch April 11, 2021 20:04
ZibanPirate added a commit that referenced this pull request Dec 5, 2021
…ommon

Refactored api response to common folder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api API related changes ( api folder ) common Common related changes ( common folder ) web Web related changes ( web folder )

Projects

Status: Released

Development

Successfully merging this pull request may close these issues.

Share API responses types/interfaces with the frontend [stage] CORS error when calling api endpoint from articles or documentation pages

3 participants