Skip to content

CHORE: removed unnecessary localization code and dependencies #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Aug 5, 2022
Merged

CHORE: removed unnecessary localization code and dependencies #469

merged 10 commits into from
Aug 5, 2022

Conversation

@ZibanPirate
Copy link
Member

@ZibanPirate ZibanPirate commented Aug 5, 2022 •
edited
Loading

Description

  • Removed react-intl
  • Added translation component factory (home-made solution)
  • Used translation component factory and localized almost everything except /Learn and /Articles pages.

Type of change

  • Code refactoring

@ZibanPirate ZibanPirate self-assigned this Aug 5, 2022
@ZibanPirate ZibanPirate linked an issue Aug 5, 2022 that may be closed by this pull request
Remove unnecessary code and dependencies #467
Closed
@github-actions github-actions bot added ui ui package web Web related changes ( web folder ) labels Aug 5, 2022
@ZibanPirate ZibanPirate marked this pull request as ready for review August 5, 2022 20:05
@ZibanPirate ZibanPirate changed the title CHORE: removed unnecessary code and dependencies CHORE: removed unnecessary localization code and dependencies Aug 5, 2022
@ZibanPirate ZibanPirate merged commit fa68531 into main Aug 5, 2022
@ZibanPirate ZibanPirate deleted the 467-remove-unnecessary-code-and-dependencies branch August 5, 2022 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@omdxp omdxp omdxp approved these changes

@abderrahmaneMustapha abderrahmaneMustapha Awaiting requested review from abderrahmaneMustapha

@souhaib-benbouzid souhaib-benbouzid Awaiting requested review from souhaib-benbouzid

Assignees

@ZibanPirate ZibanPirate

Labels

ui ui package web Web related changes ( web folder )

Projects

DzCode i/o
Status: Released

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove unnecessary code and dependencies

3 participants

@ZibanPirate @omdxp