Skip to content

feat: fix url localisation so it always use english URLs and prefix them with language code #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 6, 2022
Merged

feat: fix url localisation so it always use english URLs and prefix them with language code #470

merged 6 commits into from
Aug 6, 2022

Conversation

@ZibanPirate
Copy link
Member

@ZibanPirate ZibanPirate commented Aug 6, 2022

Description

  • added Link Component Factory in @dzcode.io/ui and used it.
  • made React Router support localization
  • We now update URL when switching languages
  • get the correct Article/Document slug with locale

Type of change

  • New feature (non-breaking change which adds functionality)

@ZibanPirate ZibanPirate self-assigned this Aug 6, 2022
@ZibanPirate ZibanPirate linked an issue Aug 6, 2022 that may be closed by this pull request
Fix URL localization (always use english and prefix with language code) #466
Closed
@github-actions github-actions bot added ui ui package web Web related changes ( web folder ) labels Aug 6, 2022
@ZibanPirate ZibanPirate requested review from a team and souhaib-benbouzid August 6, 2022 12:26
@ZibanPirate ZibanPirate merged commit 3819573 into main Aug 6, 2022
@ZibanPirate ZibanPirate deleted the 466-fix-url-localization-always-use-english-and-prefix-with-language-code branch August 6, 2022 12:39
BRAHAIM360
BRAHAIM360 reviewed Aug 6, 2022
View reviewed changes
Copy link
Contributor

@BRAHAIM360 BRAHAIM360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

@ZibanPirate ZibanPirate added the feature Feature label Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BRAHAIM360 BRAHAIM360 BRAHAIM360 left review comments

@omdxp omdxp omdxp approved these changes

@souhaib-benbouzid souhaib-benbouzid Awaiting requested review from souhaib-benbouzid

Assignees

@ZibanPirate ZibanPirate

Labels

feature Feature ui ui package web Web related changes ( web folder )

Projects

DzCode i/o
Status: Released

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix URL localization (always use english and prefix with language code)

4 participants

@ZibanPirate @BRAHAIM360 @omdxp