Skip to content

feat: update sitemap with localized links using react helmet #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 7, 2022
Merged

feat: update sitemap with localized links using react helmet #472

merged 8 commits into from
Aug 7, 2022

Conversation

@ZibanPirate
Copy link
Member

@ZibanPirate ZibanPirate commented Aug 6, 2022 •
edited
Loading

Description

working on #471

  • used react-helmet to localize title and description of static and dynamic pages
  • Updated webpack config to use locale title and description
  • localized sitemap file generation logic
  • fix: switching to "en" on root was broken
  • fix: settings not persisting in localStorage

Type of change

  • New feature (non-breaking change which adds functionality)

@ZibanPirate ZibanPirate self-assigned this Aug 6, 2022
@ZibanPirate ZibanPirate linked an issue Aug 6, 2022 that may be closed by this pull request
update sitemap with localized links using react-helmet #471
Closed
@github-actions github-actions bot added ui ui package web Web related changes ( web folder ) labels Aug 6, 2022
@ZibanPirate ZibanPirate marked this pull request as ready for review August 7, 2022 13:04
@ZibanPirate ZibanPirate requested a review from a team August 7, 2022 13:04
@ZibanPirate ZibanPirate merged commit 56ee86c into main Aug 7, 2022
@ZibanPirate ZibanPirate deleted the 471-update-sitemap-with-localized-links-using-react-helmet branch August 7, 2022 13:09
@ZibanPirate ZibanPirate added the feature Feature label Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@omdxp omdxp omdxp approved these changes

@souhaib-benbouzid souhaib-benbouzid Awaiting requested review from souhaib-benbouzid

Assignees

@ZibanPirate ZibanPirate

Labels

feature Feature ui ui package web Web related changes ( web folder )

Projects

DzCode i/o
Status: Released

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

update sitemap with localized links using react-helmet

3 participants

@ZibanPirate @omdxp