Skip to content

Conversation

@tomzo42
Copy link
Contributor

@tomzo42 tomzo42 commented Feb 26, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: CONTRIBUTING.md
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?
added api for get directory content

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #9

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@nx-cloud
Copy link

nx-cloud bot commented Feb 26, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e253b60. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 3 targets

Sent with 💌 from NxCloud.

@codecov
Copy link

codecov bot commented Feb 26, 2023

Codecov Report

Merging #68 (e253b60) into master (50aab94) will increase coverage by 3.58%.
The diff coverage is 95.23%.

@@            Coverage Diff             @@
##           master      #68      +/-   ##
==========================================
+ Coverage   66.44%   70.02%   +3.58%     
==========================================
  Files          51       56       +5     
  Lines         295      337      +42     
  Branches       15       16       +1     
==========================================
+ Hits          196      236      +40     
- Misses         99      100       +1     
- Partials        0        1       +1     
Flag Coverage Δ *Carryforward flag
cli-daemon 61.88% <95.23%> (+7.73%) ⬆️
cli-gui 93.93% <ø> (ø) Carriedforward from 50aab94
configuration 100.00% <ø> (ø) Carriedforward from 50aab94
executors 100.00% <ø> (ø) Carriedforward from 50aab94
generators 77.77% <ø> (ø) Carriedforward from 50aab94
shared ∅ <ø> (∅) Carriedforward from 50aab94
ui ∅ <ø> (∅) Carriedforward from 50aab94
workspace-manager 83.78% <ø> (ø) Carriedforward from 50aab94

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...mon/src/app/workspace-manager/dto/directory.dto.ts 88.88% <88.88%> (ø)
...app/workspace-manager/workspace-manager.service.ts 95.65% <95.65%> (ø)
...p/workspace-manager/entities/exception-messages.ts 100.00% <100.00%> (ø)
...daemon/src/app/workspace-manager/entities/index.ts 100.00% <100.00%> (ø)
.../workspace-manager/workspace-manager.controller.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tomzohar tomzohar requested review from a team and agroupp February 26, 2023 07:51
Copy link
Member

@ronnetzer ronnetzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as a general note, prefer using models and DTOs as classes instead of interfaces so you'll be able to use class-transformer features, etc

Copy link
Collaborator

@Danieliverant Danieliverant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, just align the "shoulds" :)

private readonly workspaceManagerService: WorkspaceManagerService
) {}

@Get('dir?:path')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@Get('dir?:path')
@Get('dir')

you mixed query and path params

@tomzohar tomzohar merged commit 2c830c8 into master Mar 1, 2023
@tomzohar tomzohar deleted the feat_workspace_manager/get_dir branch March 1, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants