-
Notifications
You must be signed in to change notification settings - Fork 1
feat(workspace-manager): added get directory api #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit e253b60. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 3 targetsSent with 💌 from NxCloud. |
Codecov Report
@@ Coverage Diff @@
## master #68 +/- ##
==========================================
+ Coverage 66.44% 70.02% +3.58%
==========================================
Files 51 56 +5
Lines 295 337 +42
Branches 15 16 +1
==========================================
+ Hits 196 236 +40
- Misses 99 100 +1
- Partials 0 1 +1
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
apps/cli-daemon/src/app/workspace-manager/workspace-manager.controller.ts
Outdated
Show resolved
Hide resolved
apps/cli-daemon/src/app/workspace-manager/entities/exception-messages.ts
Outdated
Show resolved
Hide resolved
apps/cli-daemon/src/app/workspace-manager/workspace-manager.service.spec.ts
Outdated
Show resolved
Hide resolved
apps/cli-daemon/src/app/workspace-manager/workspace-manager.service.spec.ts
Outdated
Show resolved
Hide resolved
apps/cli-daemon/src/app/workspace-manager/workspace-manager.service.ts
Outdated
Show resolved
Hide resolved
apps/cli-daemon/src/app/workspace-manager/workspace-manager.service.ts
Outdated
Show resolved
Hide resolved
ronnetzer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as a general note, prefer using models and DTOs as classes instead of interfaces so you'll be able to use class-transformer features, etc
apps/cli-daemon/src/app/workspace-manager/workspace-manager.service.spec.ts
Outdated
Show resolved
Hide resolved
apps/cli-daemon/src/app/workspace-manager/workspace-manager.service.ts
Outdated
Show resolved
Hide resolved
apps/cli-daemon/src/app/workspace-manager/workspace-manager.service.ts
Outdated
Show resolved
Hide resolved
apps/cli-daemon/src/app/workspace-manager/workspace-manager.service.ts
Outdated
Show resolved
Hide resolved
apps/cli-daemon/src/app/workspace-manager/workspace-manager.service.ts
Outdated
Show resolved
Hide resolved
apps/cli-daemon/src/app/workspace-manager/workspace-manager.controller.spec.ts
Outdated
Show resolved
Hide resolved
apps/cli-daemon/src/app/workspace-manager/workspace-manager.controller.spec.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, just align the "shoulds" :)
| private readonly workspaceManagerService: WorkspaceManagerService | ||
| ) {} | ||
|
|
||
| @Get('dir?:path') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| @Get('dir?:path') | |
| @Get('dir') |
you mixed query and path params
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
added api for get directory content
What is the current behavior?
Issue Number: #9
What is the new behavior?
Does this PR introduce a breaking change?
Other information