Skip to content

Conversation

@Danieliverant
Copy link
Collaborator

@Danieliverant Danieliverant commented Feb 27, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: CONTRIBUTING.md
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[X] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Styles are from the current project.

Issue Number: N/A

What is the new behavior?

Styles are from the UI lib.

Does this PR introduce a breaking change?

[X] Yes
[ ] No

@nx-cloud
Copy link

nx-cloud bot commented Feb 27, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b5d8774. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 3 targets

Sent with 💌 from NxCloud.

@Danieliverant Danieliverant requested review from a team and ronnetzer February 27, 2023 08:42
@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Merging #77 (b5d8774) into master (c89acbd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #77   +/-   ##
=======================================
  Coverage   67.88%   67.88%           
=======================================
  Files          49       49           
  Lines         274      274           
  Branches       16       16           
=======================================
  Hits          186      186           
  Misses         88       88           
Flag Coverage Δ *Carryforward flag
cli-daemon 55.00% <ø> (ø)
cli-gui 93.93% <ø> (ø)
configuration 100.00% <ø> (ø)
executors 100.00% <ø> (ø)
generators 77.77% <ø> (ø)
shared ∅ <ø> (∅) Carriedforward from 5de70b5
ui ∅ <ø> (?)
workspace-manager 83.78% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Danieliverant Danieliverant marked this pull request as ready for review February 27, 2023 09:25
@Danieliverant Danieliverant requested review from a team and ronnetzer February 27, 2023 09:25
@Danieliverant Danieliverant merged commit d4348f2 into master Feb 27, 2023
@Danieliverant Danieliverant deleted the daniel/ui-v2 branch February 27, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants