Skip to content

Conversation

@mishushakov
Copy link
Member

@mishushakov mishushakov commented Nov 11, 2025

Note

Moves config/workdir to /root, adds Docker user creation with sudo, updates startup paths, and adjusts build scripts/resources.

  • Template (template/template.py):
    • Move default workdir to /root and config envs to /root/.jupyter, /root/.ipython, /root/.server.
    • Replace set_user_workdir with is_docker flag that creates user, home dir, and grants passwordless sudo.
    • Always switch to user and set workdir to /home/user before start.
    • Start command now runs sudo /root/.jupyter/start-up.sh.
  • Startup (template/start-up.sh):
    • Use /root/.server/ and MATPLOTLIBRC=/root/.config/matplotlib/.matplotlibrc paths.
  • Build scripts:
    • build_ci.py, build_prod.py: call make_template() without set_user_workdir.
    • build_docker.py: call make_template(..., is_docker=True).
    • build_test.py: remove set_user_workdir; increase cpu_count to 2 and memory_mb to 2048.

Written by Cursor Bugbot for commit 2e068f1. This will update automatically on new commits. Configure here.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Template.build(
make_template(set_user_workdir=True),

P1 Badge Fix build_ci call to removed set_user_workdir parameter

The commit renamed make_template’s set_user_workdir flag to is_docker, but build_ci.py still calls make_template(set_user_workdir=True). That call now raises TypeError: make_template() got an unexpected keyword argument 'set_user_workdir' whenever the CI build script runs, so the CI template build will fail. Update the invocation to use the new signature or drop the flag.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Copy link
Contributor

@dobrac dobrac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just double check please the template still builds correctly with the old build system using the Docker image

@mishushakov mishushakov merged commit 496f28a into main Nov 11, 2025
9 checks passed
@mishushakov mishushakov deleted the updated-template branch November 11, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants