Fix Redis cache index accounting bugs

- Evict: Skip decrementing build counters when size is 0 to avoid corrupting per-build aggregates when cleaning ghost entries
- cleanFromBucket: Call index.Evict for bucket-driven deletes to keep Redis synchronized with GCS state

Author: cursoragent

packages/orchestrator/cmd/clean-rapid-cache/main.go

@@ -79,7 +79,7 @@ func clean(ctx context.Context, bucket string, prefix string, cutoff time.Time,
 		return nil
 	}
 
-	return cleanFromBucket(ctx, client, bucket, prefix, cutoff, maxDeletions, dryRun)
+	return cleanFromBucket(ctx, client, bucket, prefix, cutoff, maxDeletions, dryRun, index)
 }
 
 func cleanFromIndex(ctx context.Context, client *gcs.Client, bucket string, cutoff time.Time, maxDeletions int, dryRun bool, index storage.RapidCacheIndex) (int, error) {
@@ -117,7 +117,7 @@ func cleanFromIndex(ctx context.Context, client *gcs.Client, bucket string, cuto
 	return deleted, nil
 }
 
-func cleanFromBucket(ctx context.Context, client *gcs.Client, bucket string, prefix string, cutoff time.Time, maxDeletions int, dryRun bool) error {
+func cleanFromBucket(ctx context.Context, client *gcs.Client, bucket string, prefix string, cutoff time.Time, maxDeletions int, dryRun bool, index storage.RapidCacheIndex) error {
 	var scanned, matched, deleted int
 	objects := client.Bucket(bucket).Objects(ctx, &gcs.Query{Prefix: prefix})
 	for {
@@ -145,6 +145,7 @@ func cleanFromBucket(ctx context.Context, client *gcs.Client, bucket string, pre
 		if err := client.Bucket(bucket).Object(attrs.Name).Delete(ctx); err != nil {
 			return fmt.Errorf("delete cache object: %w", err)
 		}
+		_ = index.Evict(ctx, attrs.Name, attrs.Size)
 		deleted++
 	}
 

packages/shared/pkg/storage/storage_cache_rapid_index.go

@@ -92,7 +92,7 @@ func (i *redisRapidCacheIndex) Evict(ctx context.Context, path string, size int6
 	buildID := rapidCacheBuildID(path)
 	pipe := i.redis.Pipeline()
 	pipe.ZRem(ctx, i.keys.chunks, path)
-	if buildID != "" {
+	if buildID != "" && size > 0 {
 		pipe.HIncrBy(ctx, i.keys.buildBytes, buildID, -size)
 		pipe.HIncrBy(ctx, i.keys.buildChunks, buildID, -1)
 	}