Skip to content

Fix deprecation warning in CustomChainingTransport #1104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 28, 2025
Merged

Fix deprecation warning in CustomChainingTransport #1104

merged 2 commits into from
Jul 28, 2025

Conversation

Carlosespicur
Copy link
Contributor

@Carlosespicur Carlosespicur commented Jul 28, 2025 •
edited by MiguelCompany
Loading

Description

This PR fixes a deprecation warning in DDSCodeTester.cpp caused by calling SenderResource::send() without specifying the transport priority.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Code snippets related to the added documentation have been provided.
  • Documentation tests pass locally.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

@Carlosespicur
Fix deprecation warning in CustomChainingTransport
dd37a5e 
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
@Carlosespicur Carlosespicur added this to the v3.4.0 milestone Jul 28, 2025
@Carlosespicur Carlosespicur mentioned this pull request Jul 28, 2025
Merged
6 tasks
MiguelCompany
MiguelCompany requested changes Jul 28, 2025
View reviewed changes
@Carlosespicur
Apply suggestions
7e9d11b 
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
@MiguelCompany MiguelCompany requested review from richiprosima and removed request for richiprosima July 28, 2025 12:08
@MiguelCompany MiguelCompany merged commit a0e15a4 into master Jul 28, 2025
4 checks passed
@MiguelCompany MiguelCompany deleted the hotfix/deprecated-api branch July 28, 2025 12:41
This was referenced Sep 16, 2025
Merged
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees
No one assigned
Labels
ci-pending
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Carlosespicur @MiguelCompany