Skip to content

Conversation

MiguelCompany
Copy link
Member

@MiguelCompany MiguelCompany commented Sep 19, 2025

Description

This removes @feed operations from the RPC example, since this becomes a Fast DDS Pro feature

@Mergifyio backport 2.2.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Changes are API compatible.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@MiguelCompany MiguelCompany changed the title [23703] Remove feed operations from example [23703] Remove @feed operations from example Sep 19, 2025
@MiguelCompany MiguelCompany added this to the v2.4.0 milestone Sep 19, 2025
@Carlosespicur Carlosespicur self-requested a review September 23, 2025 12:47
@github-actions github-actions bot added the ci-pending PR which CI is running label Sep 23, 2025
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Copy link
Member Author

@Mergifyio backport 2.2.x

Copy link

mergify bot commented Sep 25, 2025

backport 2.2.x

✅ Backports have been created

@MiguelCompany MiguelCompany merged commit e143c3b into main Sep 25, 2025
8 checks passed
@MiguelCompany MiguelCompany deleted the feature/23701 branch September 25, 2025 10:52
mergify bot pushed a commit that referenced this pull request Sep 25, 2025
* Refs #23701. Remove feed operations from example.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #23703. Apply suggestion.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

---------

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit e143c3b)

# Conflicts:
#	fastdds_python_examples/RPCExample/generated_code/calculator.i
#	fastdds_python_examples/RPCExample/generated_code/calculatorClient.cxx
#	fastdds_python_examples/RPCExample/generated_code/calculatorPubSubTypes.cxx
#	fastdds_python_examples/RPCExample/generated_code/calculatorServer.cxx
#	fastdds_python_examples/RPCExample/generated_code/calculatorServer.hpp
#	fastdds_python_examples/RPCExample/generated_code/calculatorServerImpl.hpp
#	fastdds_python_examples/RPCExample/generated_code/calculatorTypeObjectSupport.cxx
MiguelCompany added a commit that referenced this pull request Sep 25, 2025
* Remove `@feed` operations from example (#256)

* Refs #23701. Remove feed operations from example.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #23703. Apply suggestion.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

---------

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit e143c3b)

# Conflicts:
#	fastdds_python_examples/RPCExample/generated_code/calculator.i
#	fastdds_python_examples/RPCExample/generated_code/calculatorClient.cxx
#	fastdds_python_examples/RPCExample/generated_code/calculatorPubSubTypes.cxx
#	fastdds_python_examples/RPCExample/generated_code/calculatorServer.cxx
#	fastdds_python_examples/RPCExample/generated_code/calculatorServer.hpp
#	fastdds_python_examples/RPCExample/generated_code/calculatorServerImpl.hpp
#	fastdds_python_examples/RPCExample/generated_code/calculatorTypeObjectSupport.cxx

* Fix conflicts.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

---------

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants