Implement Check Phase Ruleset #46
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #45
Implemented rules
RootDataEntity-->mentionsSHOULD reference theCheckValueentityCheckValueentity MUST haveadditionalTypewith@idofhttps://w3id.org/shp#CheckValue(i)CheckValueentity MUST be of typeAssessActionnameof theCheckValueentity MUST provide a human-readable summary of the review and result (ii)CheckValue-->objectSHOULD point to the root of the RO-Crate.CheckValue-->instrumentSHOULD point to an entity typedschema:DefinedTermCheckValueentity MAY havestartTimeproperty if action beganCheckValue-->startTimeMUST follows the RFC 3339 standard.CheckValueentity SHOULD haveendTimeproperty if action endedCheckValue-->endTimeMUST follows the RFC 3339 standard.CheckValueentity SHOULD haveactionStatuspropertyCheckValue-->actionStatusMUST have one of the allowed valuesCheckValue-->agentSHOULD reference the agent who initiated the check (iii)(i) Rule 2 is not an actual rule, but rather a definition of what constitutess a CheckPhase object. Hence it is not possible to code it, given its axiomatic nature.
(ii) This cannot be entirely done without a manual check. Here we only check that the
nameproperty of the Check Phase object is a string of at least 20 characters.(iii) All we are enforcing / testing here is that
checkValuehas a propertyagentwhich points to an IRI.Rules not implemented (they need some clarification)