layout fixes #1056
Merged
layout fixes #1056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should lead to smaller XAR size. Removed font from - npm dependencies - xar-resources folder - frontend folder Adapted the gulpfile accordingly.
unnecessary duplication of resources in - src/main/frontend/copy - src/main/xar-resources/resources
- move svgs from src/main/frontend/img to src/main/frontend/svg - adapt Gulpfile - remove duplicates in src/main/xar-resoures/resources/images
- introduce color variables - unified and correct brand colors - more prominent search button in the navbar - fixed burger-icon for mobile view - fixed footer - fixed page alignment - improve sidebar (toc and button) - crispy project logo - less markup for more impact
duncdrum
approved these changes
Jan 3, 2025
Contributor
|
see #1055 |
reinhapa
approved these changes
Jan 3, 2025
- search form - buttons - breadcrumb - colors - scss build (no need to import minified bootstrap)
Member
Author
|
Also the site now looks nicer on smaller screens |
duncdrum
requested changes
Jan 6, 2025
Contributor
duncdrum
left a comment
duncdrum
left a comment
There was a problem hiding this comment.
i would then also remove minified bootstrap css from here
https://github.com/line-o/documentation/blob/4ba75ea72f08d9f248ed689927c6c9c20c0e1d6c/Gulpfile.js#L285
- code blocks have a dark background - styles are all in one place and structured
Member
Author
|
@duncdrum this needs to be there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before
after