-
-
Notifications
You must be signed in to change notification settings - Fork 45
Collection configuration MUST be collection.xconf #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
data/indexing.xml
Outdated
| collection. Note, however, that configuration settings do not cascade. If you choose | ||
| to deploy a <filename>collection.xconf</filename> file in a subcollection, you must | ||
| collection. Note, however, that configuration settings do not cascade, that is to say that a sub-Collection | ||
| with a <filename>collectio.xconf</filename>, will not inherit any settings from any ancestor Collection |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo in .xco file name
data/indexing.xml
Outdated
| collection. Note, however, that configuration settings do not cascade. If you choose | ||
| to deploy a <filename>collection.xconf</filename> file in a subcollection, you must | ||
| collection. Note, however, that configuration settings do not cascade, that is to say that a sub-Collection | ||
| with a <filename>collectio.xconf</filename>, will not inherit any settings from any ancestor Collection |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Collectio iso collection I mean
|
@dizzzz All fixed :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We now have more alternating spellings than before of subcollection and sub-collection. Can we make it consistent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK!
|
Can we do that in a subsequent PR? It probably needs to be done across all
docs!
…On 26 Sep 2017 2:45 p.m., "ljo" ***@***.***> wrote:
***@***.**** commented on this pull request.
We now have more alternating spellings than before of subcollection and
sub-collection. Can we make it consistent?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#132 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABNJud8j7EnP2F3UameOrRK19-utNeMsks5smP_rgaJpZM4PjXOV>
.
|
|
Sure, I, can do that across all docs. |
|
oops, by pulling in @ljo this needs rework .... |
|
reworked @adamretter 's change .... |
59fbd71 to
ce6c243
Compare
Closes eXist-db/exist#1282