This repository was archived by the owner on May 29, 2022. It is now read-only.
Move typings to devDependencies #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leaving @types in dependencies causes them to be installed when @easy-webpack/core is installed, inferring with the application using easy-webpack. Typings are not required for using easy-webpack, only for development of easy-webpack. It's especially important in case of @types/nodes which overrides some methods such as setTimeout which causes compilation error.
Contributor
|
This should be alright except for the lodash dependency, part of which is exposed by easy-webpack itself. Thanks. |
niieani
added a commit
to easy-webpack/assign
that referenced
this pull request
Nov 8, 2016
niieani
added a commit
to easy-webpack/config-aurelia
that referenced
this pull request
Nov 8, 2016
niieani
added a commit
to easy-webpack/config-babel
that referenced
this pull request
Nov 8, 2016
niieani
added a commit
to easy-webpack/config-common-chunks-simple
that referenced
this pull request
Nov 8, 2016
niieani
added a commit
to easy-webpack/config-copy-files
that referenced
this pull request
Nov 8, 2016
niieani
added a commit
to easy-webpack/config-css
that referenced
this pull request
Nov 8, 2016
niieani
added a commit
to easy-webpack/config-electron
that referenced
this pull request
Nov 8, 2016
niieani
added a commit
to easy-webpack/config-electron-main
that referenced
this pull request
Nov 8, 2016
niieani
added a commit
to easy-webpack/config-electron-renderer
that referenced
this pull request
Nov 8, 2016
niieani
added a commit
to easy-webpack/config-env-development
that referenced
this pull request
Nov 8, 2016
niieani
added a commit
to easy-webpack/config-env-production
that referenced
this pull request
Nov 8, 2016
niieani
added a commit
to easy-webpack/config-eslint
that referenced
this pull request
Nov 8, 2016
niieani
added a commit
to easy-webpack/config-external-source-maps
that referenced
this pull request
Nov 8, 2016
niieani
added a commit
to easy-webpack/config-fonts-and-images
that referenced
this pull request
Nov 8, 2016
niieani
added a commit
to easy-webpack/config-generate-index-html
that referenced
this pull request
Nov 8, 2016
niieani
added a commit
to easy-webpack/config-global-bluebird
that referenced
this pull request
Nov 8, 2016
niieani
added a commit
to easy-webpack/config-global-jquery
that referenced
this pull request
Nov 8, 2016
niieani
added a commit
to easy-webpack/config-global-regenerator
that referenced
this pull request
Nov 8, 2016
niieani
added a commit
to easy-webpack/config-html
that referenced
this pull request
Nov 8, 2016
niieani
added a commit
to easy-webpack/config-json
that referenced
this pull request
Nov 8, 2016
niieani
added a commit
to easy-webpack/config-less
that referenced
this pull request
Nov 8, 2016
niieani
added a commit
to easy-webpack/config-offline
that referenced
this pull request
Nov 8, 2016
niieani
added a commit
to easy-webpack/config-output-library
that referenced
this pull request
Nov 8, 2016
niieani
added a commit
to easy-webpack/config-pug
that referenced
this pull request
Nov 8, 2016
niieani
added a commit
to easy-webpack/config-sass
that referenced
this pull request
Nov 8, 2016
niieani
added a commit
to easy-webpack/config-source-map-support
that referenced
this pull request
Nov 8, 2016
niieani
added a commit
to easy-webpack/config-test-coverage-istanbul
that referenced
this pull request
Nov 8, 2016
niieani
added a commit
to easy-webpack/config-tslint
that referenced
this pull request
Nov 8, 2016
niieani
added a commit
to easy-webpack/config-typescript
that referenced
this pull request
Nov 8, 2016
niieani
added a commit
to easy-webpack/config-uglify
that referenced
this pull request
Nov 8, 2016
niieani
added a commit
that referenced
this pull request
Nov 8, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leaving @types in dependencies causes them to be installed when @easy-webpack/core is installed, inferring with the application using easy-webpack. Typings are not required for using easy-webpack, only for development of easy-webpack. It's especially important in case of @types/nodes which overrides some methods such as setTimeout which causes compilation error.
┆Issue is synchronized with this Asana task