-
Notifications
You must be signed in to change notification settings - Fork 11
feat(): support emit render info #2285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d735d99 to
ad5a854
Compare
| const history = getHistory(); | ||
| history.unblock(); | ||
|
|
||
| const renderStartTime = Date.now(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
建议使用 performance.now()
835e8bf to
fbb681c
Compare
fbb681c to
2bac5d0
Compare
Pull Request Test Coverage Report for Build 3225067093
💛 - Coveralls |
| this.kernel.bootstrapData.settings?.misc ?? {}; | ||
| if (currentApp.isBuildPush && loadTime > 0 && renderTime > loadTime) { | ||
| const getSecond = (time: number): number => | ||
| Math.floor(time * 100) / 100; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里计算的时候进行了 floor,但是前面判断的时候却没有 floor,那么可能出现这种情况:renderTime = 2.509s,提示用户超时,但是,界面上会显示为「您的页面存在性能问题, 当前页面渲染时间为: 2.5s,规定阈值为: 2.5s」,这有些奇怪。
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
依赖检查
组件之间的依赖声明,是微服务组件架构下的重要信息,请确保其正确性。
请勾选以下两组选项其中之一:
或者:
提交信息检查
Git 提交信息将决定包的版本发布及自动生成的 CHANGELOG,请检查工作内容与提交信息是否相符,并在以下每组选项中都依次确认。
破坏性变更:
feat作为提交类型。BREAKING CHANGE: 你的变更说明。新特性:
feat作为提交类型。问题修复:
fix作为提交类型。杂项工作:
即所有对下游使用者无任何影响、且没有必要显示在 CHANGELOG 中的改动,例如修改注释、测试用例、开发文档等:
chore,docs,test等作为提交类型。