-
Notifications
You must be signed in to change notification settings - Fork 2
Hotfix 1.4.1 - downgrade svglib to avoid missing libcairo on Ubuntu #267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Also, sneakily added a requested minor feature: |
damskii9992
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here, you're filtering out zero-variance values when loading the dataset. I originally though we would just do it when we do the fitting and maybe plot them differently when plotting them to show that they're being filtered out. At least, that is how I plan to do it in EasyImaging.
Hmm yes this makes sense. We still want to have them available, since this is the dataset we loaded. |
contain pristine datasets
damskii9992
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, this is also much simpler than the previous way of masking out during loading ^^
xhtml2pdf has svglib as a dependency. This module doesn't pin the version of
pycairo, which in its recent version began to requirelibcairoto be installed on the Linux host.We can't require users to install this library BEFORE installing EasyReflectometryLib, so we need to either replace xhtml2pdf or wait for the issue in svglib to be fixed.
Temporarily we can downgrade
svglibso the old pycairo is installed.