Skip to content

Conversation

@rozyczko
Copy link
Member

@rozyczko rozyczko commented Oct 2, 2025

xhtml2pdf has svglib as a dependency. This module doesn't pin the version of pycairo, which in its recent version began to require libcairo to be installed on the Linux host.
We can't require users to install this library BEFORE installing EasyReflectometryLib, so we need to either replace xhtml2pdf or wait for the issue in svglib to be fixed.
Temporarily we can downgrade svglib so the old pycairo is installed.

@rozyczko rozyczko added [scope] bug Bug report or fix (major.minor.PATCH) bugfix Fix to known bug [priority] highest Urgent. Needs attention ASAP labels Oct 2, 2025
@rozyczko
Copy link
Member Author

rozyczko commented Oct 3, 2025

Also, sneakily added a requested minor feature:
if any zero variance is present in the input, disregard the point and notify the user

@rozyczko rozyczko requested a review from damskii9992 October 3, 2025 13:26
Copy link
Contributor

@damskii9992 damskii9992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, you're filtering out zero-variance values when loading the dataset. I originally though we would just do it when we do the fitting and maybe plot them differently when plotting them to show that they're being filtered out. At least, that is how I plan to do it in EasyImaging.

@rozyczko
Copy link
Member Author

rozyczko commented Oct 3, 2025

Here, you're filtering out zero-variance values when loading the dataset. I originally though we would just do it when we do the fitting and maybe plot them differently when plotting them to show that they're being filtered out. At least, that is how I plan to do it in EasyImaging.

Hmm yes this makes sense. We still want to have them available, since this is the dataset we loaded.
Only the fitting should be affected, and maybe some resolution functions which rely on variance.

Copy link
Contributor

@damskii9992 damskii9992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this is also much simpler than the previous way of masking out during loading ^^

@rozyczko rozyczko merged commit 08ecd5f into master Oct 6, 2025
25 checks passed
@rozyczko rozyczko deleted the hotfix_1.4.1 branch October 13, 2025 14:37
rozyczko added a commit that referenced this pull request Oct 14, 2025
* update version number

* Hotfix 1.4.1 - downgrade svglib to avoid missing libcairo on Ubuntu (#267)

* pin svglib to avoid libcairo recompilation on linux
* check/mask zero variances before the fitting.

* version update (#268)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Fix to known bug [priority] highest Urgent. Needs attention ASAP [scope] bug Bug report or fix (major.minor.PATCH)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants