Skip to content

Conversation

@rozyczko
Copy link
Member

This class had ZERO unit test coverage. Now we have it covered.

Also, added codecov.

For this branch, check out
https://app.codecov.io/gh/EasyScience/corelib/tree/interface_factory_unit_tests

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['chore', 'fix', 'bugfix', 'bug', 'enhancement', 'feature', 'dependencies', 'documentation']

@rozyczko rozyczko added chore PR label [scope] maintenance Code/tooling cleanup, no feature or bugfix (major.minor.PATCH) [priority] medium Normal/default priority labels Oct 16, 2025
@rozyczko
Copy link
Member Author

The current unit test coverage is a bit over 75%. Need to improve that to at least 80%

@codecov
Copy link

codecov bot commented Oct 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.10%. Comparing base (952da19) to head (2fb42f4).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #151      +/-   ##
===========================================
+ Coverage    73.14%   80.10%   +6.95%     
===========================================
  Files           48       48              
  Lines         4092     4091       -1     
  Branches       715      715              
===========================================
+ Hits          2993     3277     +284     
+ Misses         896      630     -266     
+ Partials       203      184      -19     
Flag Coverage Δ
unittests 80.10% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/easyscience/global_object/map.py 89.41% <100.00%> (+37.31%) ⬆️

... and 5 files with indirect coverage changes

@rozyczko rozyczko marked this pull request as draft October 17, 2025 08:29
@rozyczko
Copy link
Member Author

It's 79.71% 💀
I'm stopping here

@rozyczko rozyczko marked this pull request as ready for review October 17, 2025 09:37
Copy link
Member

@henrikjacobsenfys henrikjacobsenfys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too familiar with the interface factory and global object, but it looks good to me. I have only two minor comments/questions.

@damskii9992
Copy link
Contributor

Shouldn't this PR go into develop? Why is it going into Master?

@rozyczko
Copy link
Member Author

Shouldn't this PR go into develop? Why is it going into Master?

because I'm a blind numpty. Fixed.

@rozyczko rozyczko changed the base branch from master to develop October 28, 2025 14:20
@rozyczko rozyczko mentioned this pull request Nov 4, 2025
@rozyczko
Copy link
Member Author

rozyczko commented Nov 4, 2025

80.23%. There we go.

@rozyczko rozyczko merged commit b5169f5 into develop Nov 19, 2025
35 checks passed
@rozyczko rozyczko deleted the interface_factory_unit_tests branch November 19, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore PR label [priority] medium Normal/default priority [scope] maintenance Code/tooling cleanup, no feature or bugfix (major.minor.PATCH)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants