-
Notifications
You must be signed in to change notification settings - Fork 2
Interface factory unit tests #151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request does not contain a valid label. Please add one of the following labels: ['chore', 'fix', 'bugfix', 'bug', 'enhancement', 'feature', 'dependencies', 'documentation']
|
The current unit test coverage is a bit over 75%. Need to improve that to at least 80% |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #151 +/- ##
===========================================
+ Coverage 73.14% 80.10% +6.95%
===========================================
Files 48 48
Lines 4092 4091 -1
Branches 715 715
===========================================
+ Hits 2993 3277 +284
+ Misses 896 630 -266
+ Partials 203 184 -19
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
It's 79.71% 💀 |
henrikjacobsenfys
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not too familiar with the interface factory and global object, but it looks good to me. I have only two minor comments/questions.
|
Shouldn't this PR go into develop? Why is it going into Master? |
because I'm a blind numpty. Fixed. |
|
80.23%. There we go. |
This class had ZERO unit test coverage. Now we have it covered.
Also, added codecov.
For this branch, check out
https://app.codecov.io/gh/EasyScience/corelib/tree/interface_factory_unit_tests