-
Notifications
You must be signed in to change notification settings - Fork 2
22 add test for minimizers and confirm that dfo is working #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Parent:
Preparation for 2.0.0 release
damskii9992
merged 17 commits into
develop
from
22-add-test-for-minimizers-and-confirm-that-dfo-is-working
Jul 17, 2024
Merged
22 add test for minimizers and confirm that dfo is working #26
damskii9992
merged 17 commits into
develop
from
22-add-test-for-minimizers-and-confirm-that-dfo-is-working
Jul 17, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request does not contain a valid label. Please add one of the following labels: ['chore', 'fix', 'bugfix', 'bug', 'enhancement', 'feature', 'dependencies', 'documentation']
380d747 to
0ec24a7
Compare
damskii9992
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minimizer_dfois now doing a normalization of the parameters if bounds are providedRefactoring to make the code more reusable / testable of:
minimizer_baseminimizer_lmfitTests for:
minimizer_baseminimizer_lmfitMaking it more clear where the new_variable is imported and used