Skip to content

Conversation

@andped10
Copy link
Contributor

@andped10 andped10 commented Jul 6, 2024

minimizer_dfo is now doing a normalization of the parameters if bounds are provided

Refactoring to make the code more reusable / testable of:

  • minimizer_base
  • minimizer_lmfit

Tests for:

  • minimizer_base
  • minimizer_lmfit

Making it more clear where the new_variable is imported and used

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['chore', 'fix', 'bugfix', 'bug', 'enhancement', 'feature', 'dependencies', 'documentation']

@andped10 andped10 added chore PR label fitting Umbrella for fitting related work labels Jul 6, 2024
@andped10 andped10 marked this pull request as ready for review July 6, 2024 07:49
@damskii9992 damskii9992 force-pushed the 22-add-test-for-minimizers-and-confirm-that-dfo-is-working branch from 380d747 to 0ec24a7 Compare July 16, 2024 12:53
@damskii9992 damskii9992 added the bugfix PR label label Jul 17, 2024
@damskii9992 damskii9992 linked an issue Jul 17, 2024 that may be closed by this pull request
@damskii9992 damskii9992 merged commit ad204ee into develop Jul 17, 2024
@damskii9992 damskii9992 deleted the 22-add-test-for-minimizers-and-confirm-that-dfo-is-working branch July 17, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix PR label chore PR label fitting Umbrella for fitting related work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add test for minimizers and confirm that DFO is working

2 participants