38 add tests for minimizer bumps #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
rozyczko
reviewed
Aug 5, 2024
| def test_available_methods(self, minimizer: Bumps) -> None: | ||
| # When Then Expect | ||
| assert minimizer.available_methods() == ['amoeba', 'de', 'dream', 'newton', 'scipy.leastsq', 'lm', 'pt'] | ||
|
|
There was a problem hiding this comment.
The pt method in Bumps is experimental and shouldn't really be used. Also, why is scipy here?
There was a problem hiding this comment.
OK, we will then have to filter the raw output from bumps.
I guess it is called scipy.leastsq because it utilizes the scipy implementation. From the bumps code it appears that LevenbergMarquardtFit is called scipy.leastsq but there is also an internal version that is referred to as lm. The name for this minimizer will be left as is.
…/EasyScience/EasyScience into 38-add-tests-for-minimizer-bumps
rozyczko
approved these changes
Aug 6, 2024
rozyczko
added a commit
to rozyczko/EasyScience
that referenced
this pull request
Aug 15, 2024
PR related fixes ruff, be quiet. renamed Job->job directory name 38 add tests for minimizer bumps (easyscience#41) * tests and adjustments * handling circular dependency * Updated minimizer names * Made ruff happy * pr response * more consistent usage of enum --------- Co-authored-by: henrikjacobsenfys <henrik.jacobsen.fys@gmail.com> removed unnecessary empty line minimizer consolidation (easyscience#45) * minimizer consolidation * pr response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for Bumps.
Changed order of method in Bumps to have the public methods appear first. No changes to logic
Changed how imports of
new_parameteris done inminimizer_lm_fit.pyto prevent circular imports when importingFitter.