Skip to content

Conversation

@andped10
Copy link
Contributor

@andped10 andped10 commented Sep 13, 2024

Cleaned up AvailableMinimizers

Various places we also accept DescriptorBase as valid type for moving on.

All classes now accepts unique_name as argument to constructor

Made a __copy__ method for ObjectClasses

Got rid of @id

Moved Constraints to repo root to break circular dependency

Cleaned map class

Tests of utils are now using the new Parameter and DecriptorNumber

@andped10 andped10 added the chore PR label label Sep 13, 2024
@andped10 andped10 marked this pull request as ready for review September 13, 2024 12:56
Copy link
Member

@henrikjacobsenfys henrikjacobsenfys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Co-authored-by: henrikjacobsenfys <henrik.jacobsen.fys@gmail.com>
@andped10 andped10 merged commit 805b721 into develop Sep 18, 2024
32 checks passed
@andped10 andped10 deleted the adjustments-to-fit-app branch September 18, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore PR label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants