Skip to content

Implement server #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 46 commits into from
Jun 16, 2025
Merged

Implement server #15

merged 46 commits into from
Jun 16, 2025

Conversation

@JAB1305
Copy link
Contributor

@JAB1305 JAB1305 commented Jun 6, 2025 •
edited
Loading

This provides a basic and incomplete implementation of a http server.

Core features being:

  • Modular structure with subservices
  • Many core endpoints implemented with according high coverage unit-tests
  • Clear structure for better readability and maintainability

For further information see

  • README.md - Implementation status of specific endpoints & features
  • DESIGN_NOTES.md - Some general thoughts about how and why this project is structured

JAB1305 and others added 30 commits December 10, 2024 12:48
@JAB1305
sdk/server: Add basic implementation of some endpoints
eb2d2dd 
Provide an example for the structure used
Add DESIGN_NTOES.md further explaining design choices
@JAB1305
/sdk/basyx/serer/submodel: Add more endpoints
fe23a74 
Adjust not implemented message to distinguish between endpoints "not yet implemented" and endpoints that were "not implemented" in the old basyx-python-sdk
@JAB1305 @somsonson
sdk/basyx/server: Moved to /server
8f0a58c 
Moved server package to top level
Created new AASX File Server router

Co-Authored-By: Simon <88947258+somsonson@users.noreply.github.com>
@JAB1305
api/README.md: Add development status as server README file
c6535e8 
Also adjusted some return value placeholders
@somsonson
api/pyproject.toml: Update pyproject to contain required dependencies
7c56034
@somsonson
update .gitignore
c923af7
@somsonson
api/server: fix python imports and codestyle
cad1886
@somsonson
object_store: Add delete function to delete by id and not only by ins…
cba1723 
…tance
@somsonson
api/server/aasx: Add AASX File Server Interface
308ddb6
@somsonson
api/README.md: AASX File Server Interface and Operations specified in…
6ffa7d8 
… README
@JAB1305
api/README.md: Update formatting and add all endpoints
675f788
@somsonson
api/server: Add aas registry server and submodel registry server to s…
b9a9668 
…erver. sdk/basyx/object_store: add filter function
@somsonson
uptdate readme.md
0a39608
@somsonson
api/server: Fix imports to support unittests.
41aafb8
@JAB1305
api/server: Add submodelElement related endpoints
b48aa8e 
Add some testcases covering basic submodel interaction
Add GET/POST/PUT/DELETE endpoints regarding specific submodelElements in a submodel
@JAB1305
Restructure imports following PEP 8
7c4adeb
@somsonson
(Hopefully) Resolve imports conflicts by using primarily absolute imp…
55bc7d2 
…orts
@somsonson
modify testing structure in /api/server/test
8120a88
@somsonson
fix issue with compatibility to python 3.8
ea18cc7
@somsonson
Add testfiles and include server tests in CI
b5846db
@somsonson
add server test to CI
f33e700
@somsonson
fix testing environment in CI
25b7ffc
@somsonson
fix typo
ed2e483
@somsonson
fix yet another import mistake
c38c86d
@somsonson
fix multiple backwards compatibility problems
582f44c
@somsonson
fix backwards compatility for python 3.8
813e961
@somsonson
fix more possible compatibility conflicts
b26f1b4
@JAB1305
Stuff
5ea5797
@JAB1305
Finish AAS, Update tests, Update URLs
9d75cf2
@JAB1305
Merge branch 'server-fixed-imports' into server
6904345
JAB1305 added 13 commits March 2, 2025 00:14
@JAB1305
Fix imports, fix tests
31c124e
@JAB1305
api/test: Resolve issues with relative json paths
8f89954
@JAB1305
api/test: Adjust aasx test so every case can be executed independantly
c50e183
@JAB1305
aasx_server: Remove redundant slashes at the end of path to fix unitt…
44f57ed 
…ests
@JAB1305
api/test/test_aas_service.py: Fix teardown so tests dont influence ea…
bde3c8d 
…ch other
@JAB1305
api: Resolve Union and List style affecting python 3.8 compatibility
a822dcb
@JAB1305
api/server/services/aasservice.py: Delete file as its duplicate and e…
23b3a05 
…mpty
@JAB1305
/api: Add put shell endpoint and unit test
0f9934d
@JAB1305
api/README.md: Update AASX File server status table
3eed6ae
@JAB1305
/api: Add asset-information endpoints and tests
4c55370
@JAB1305
api/README.md: Update submodel service endpoint addresses
0a51dcc
@JAB1305
/api: Add more tests based on coverage report
59a6595
@JAB1305
api/server/services: Update exception handling to a CustomErrorResponse
8729770 
This should allow a response scheme that provides more information and sort of matches the way error feedback is specified
s-heppner
s-heppner requested changes Jun 16, 2025
View reviewed changes
s-heppner
s-heppner approved these changes Jun 16, 2025
View reviewed changes
Copy link
Contributor

@s-heppner s-heppner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the missing empty lines at the end of the files that I just added, this LGTM

@s-heppner s-heppner merged commit 3b5ccfa into eclipse-basyx:server Jun 16, 2025
8 checks passed
@s-heppner s-heppner deleted the server branch June 16, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@s-heppner s-heppner s-heppner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JAB1305 @s-heppner @somsonson