Skip to content

Conversation

@paullatzelsperger
Copy link
Member

@paullatzelsperger paullatzelsperger commented Sep 22, 2022

What this PR changes/adds

moves all code, that was previously located in tooling/module-processor, tooling/module-processor-extension-test and module/processor-spi-test here.

Why it does that

Preparatory work for the implementation of the autodoc plugin

Further notes

The code has not been removed from EDC yet. A respective PR will follow in the EDC repo shortly.
Also, this PR is not about implementing the plugin, simply about moving the code.

Linked Issue(s)

Contributes to eclipse-edc/Connector#1998

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • assigned appropriate label? (exclude from changelog with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

@paullatzelsperger paullatzelsperger added documentation Improvements or additions to documentation build labels Sep 22, 2022
return false; // processing rounds are complete, return
}

moduleBuilder.provides(moduleIntrospector.resolveProvidedServices(environment));

Check warning

Code scanning / CodeQL

Dereferenced variable may be null

Variable [moduleBuilder](1) may be null here as suggested by [this](2) null guard.
@paullatzelsperger paullatzelsperger changed the title feat(doc): moves all autdoc code here chore: moves all autdoc code here Sep 22, 2022
@paullatzelsperger paullatzelsperger marked this pull request as ready for review September 22, 2022 12:03
@paullatzelsperger paullatzelsperger force-pushed the feature/move_autodoc_code_here branch from 42badb5 to 949995f Compare September 22, 2022 12:03
@paullatzelsperger paullatzelsperger merged commit b481736 into eclipse-edc:main Sep 22, 2022
@paullatzelsperger paullatzelsperger deleted the feature/move_autodoc_code_here branch September 22, 2022 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants