Handle Sirius forced resourceSet #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in some situations, the resourceSet we create is not used by Sirius for its session. In that case, we need to load the model from this resourceSet instead o the one we created. Signed-off-by: Didier Vojtisek <didier.vojtisek@inria.fr>
Signed-off-by: Didier Vojtisek <didier.vojtisek@inria.fr>
dvojtise
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With some models, Sirius session returns a new resourceSet instead of using the one we provided in the DefaultModelLoader. (ex: Capella)
This ends up with 2 different resources, one for the execution and one for the animation.
This PR makes sure to get a single resource (the one create by the sirius session)
However, I'm not sure this can also handle melange query (ie. "downcasting" model) so I added a warning if this situation occurs while using melange queries.