Skip to content

test(core) unit tests for registry service (EWC-383) #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2019
Merged

test(core) unit tests for registry service (EWC-383) #476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 20 additions & 17 deletions src/services/registry-service.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,21 +43,16 @@ const createRegistry = async function (registry, user, transaction) {
registryCreate = AppHelper.deleteUndefinedFields(registryCreate);

const createdRegistry = await RegistryManager.create(registryCreate, transaction);
await updateChangeTracking(user, transaction);

await _updateChangeTracking(user, transaction);

return {
id: createdRegistry.id
}
};

const updateChangeTracking = async function (user, transaction) {
let fogs = await FogManager.findAll({userId: user.id}, transaction);
for (fog of fogs) {
await ChangeTrackingService.update(fog.uuid, ChangeTrackingService.events.registries, transaction);
}
};

const findRegistries = async function (user, isCli, transaction) {
const queryRegistry = isCli
const findRegistries = async function (user, isCLI, transaction) {
const queryRegistry = isCLI
? {}
: {
[Op.or]:
Expand All @@ -77,20 +72,20 @@ const findRegistries = async function (user, isCli, transaction) {
}
};

const deleteRegistry = async function (registryData, user, isCli, transaction) {
await Validator.validate(registryData, Validator.schemas.registryDelete)
const queryData = isCli
const deleteRegistry = async function (registryData, user, isCLI, transaction) {
await Validator.validate(registryData, Validator.schemas.registryDelete);
const queryData = isCLI
? {id: registryData.id}
: {id: registryData.id, userId: user.id};
const registry = await RegistryManager.findOne(queryData, transaction);
if (!registry) {
throw new Errors.NotFoundError(AppHelper.formatMessage(ErrorMessages.INVALID_REGISTRY_ID, registryData.id));
}
if (isCli) {
if (isCLI) {
user = {id: registry.userId};
}
await RegistryManager.delete(queryData, transaction);
await updateChangeTracking(user, transaction);
await _updateChangeTracking(user, transaction);
};

const updateRegistry = async function (registry, registryId, user, isCLI, transaction) {
Expand Down Expand Up @@ -131,12 +126,20 @@ const updateRegistry = async function (registry, registryId, user, isCLI, transa

await RegistryManager.update(where, registryUpdate, transaction);

await updateChangeTracking(user, transaction);
await _updateChangeTracking(user, transaction);
};


const _updateChangeTracking = async function (user, transaction) {
let fogs = await FogManager.findAll({userId: user.id}, transaction);
for (fog of fogs) {
await ChangeTrackingService.update(fog.uuid, ChangeTrackingService.events.registries, transaction);
}
};

module.exports = {
findRegistries: TransactionDecorator.generateTransaction(findRegistries),
createRegistry: TransactionDecorator.generateTransaction(createRegistry),
findRegistries: TransactionDecorator.generateTransaction(findRegistries),
deleteRegistry: TransactionDecorator.generateTransaction(deleteRegistry),
updateRegistry: TransactionDecorator.generateTransaction(updateRegistry)
};
Loading