- 
                Notifications
    
You must be signed in to change notification settings  - Fork 775
 
WIP: Jenkins: Allow inheritance when defining build specs #2016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
21eb39e    to
    a34913e      
    Compare
  
    | 
           This is still a WIP since I still have to do a bit of cleanup and and documentation work to do. However here are some brief notes a bout the changes: 
  | 
    
a34913e    to
    75197a8      
    Compare
  
    | 
           Jenkins test sanity win  | 
    
| 
           jenkins compile win  | 
    
| 
           jenkins compile win jdk9  | 
    
| 
           jenkins test extended xlinux  | 
    
| 
           jenkins test extended xlinux jdk9  | 
    
75197a8    to
    51466ec      
    Compare
  
    | 
           Jenkins test sanity win jdk10  | 
    
7c0fbc1    to
    1c5a4b5      
    Compare
  
    This greatly reduces duplication in the build specs [skip ci] Signed-off-by: Devin Nakamura <devinn@ca.ibm.com>
| 
           Jenkins test sanity win,xlinux jdk10  | 
    
| 
           YAML has a feature called anchors. The anchors can be used to avoid duplication (no need for another class): linux_x86-64, linux_x86-64_cmprssptrs extend linux_x86-64_common:  | 
    
| 
           @dnakamura please have a look at YAML anchors  | 
    
| 
           The problem with YAML anchors is that the "extension" semantics only support map types. This is fine for most of our needs but it falls flat when it comes to   | 
    
| 9: '/cygdrive/c/openjdk/jdk8' | ||
| 10: '/cygdrive/c/openjdk/jdk9' | ||
| release: 'windows-x86_64-normal-server-release' | ||
| freemarker: '/cygdrive/c/openjdk/freemarker.jar' | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI #2118
| 
           @dnakamura can you rebase this and restart any conversations needed to get this merged  | 
    
This greatly reduces duplication in the build specs