Uploading JUnit badge has incorrect conditional

[jonahgraham]

The condition in junit.yml causes the JUnit badge to be updated on all PRs. This is because (IIUC) the junit.yml always runs on master because it runs with more privileges than maven.yml.

This conditional needs to be fixed (not sure to exactly what yet)

eclipse.platform.swt/.github/workflows/junit.yml

Line 74 in 4241119

if: github.ref == 'refs/heads/master'

Take an example, https://github.com/eclipse-platform/eclipse.platform.swt/pull/2781/checks?check_run_id=55408269138 was created at 8:16am today my time, which corresponds to this run of the junit.yml https://github.com/eclipse-platform/eclipse.platform.swt/actions/runs/19365728713 which you can see on this line is uploading the badge:

Gist updated, written: badge.svg

You can also see the problem by looking at the revisions on the badge itself. It shows a couple of dozen revisions in the last 24 hours, but there have only been a handful of commits to master branch.

This means, with my fix in #2778, while the README.md publishes the expected badge, it continues to show incorrect information.

The common publishTestResults may have a similar issue, but AFAICT no projects are providing a gist-url so no badge is being made for other consumers.

cc @laeubi Do you have any insights on this? Does the above make sense?

[laeubi]

@jonahgraham I have not really looked much into this as not many peopel seem to be interested, but the idea is of course that the badge is only updated due to a run on the master build itself.

If you want to play around with this feel free to improve or I can take a deeper look later on!

[jonahgraham]

Its not urgent - the badge has been wrong forever, so it will continue to be wrong going forward. I will resume looking at this properly once I get some other things done. I am tying this into #2714 (comment) and #2764

[jonahgraham]

The original example in the docs had the same bug that was copied/pasted into our workflows EnricoMi/publish-unit-test-result-action@5121f36

Current version https://github.com/EnricoMi/publish-unit-test-result-action/blob/34d7c956a59aed1bfebf31df77b8de55db9bbaaf/README.md?plain=1#L814-L816