Skip to content

[win32] add GetDpiForWindow OS call #1862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 8, 2025
Merged

[win32] add GetDpiForWindow OS call #1862

merged 1 commit into from
Mar 8, 2025

Conversation

@akoch-yatta
Copy link
Contributor

@akoch-yatta akoch-yatta commented Feb 26, 2025

This PR adds the OS call for GetDpiForWindow.

@akoch-yatta akoch-yatta mentioned this pull request Feb 26, 2025
Merged
@akoch-yatta akoch-yatta linked an issue Feb 26, 2025 that may be closed by this pull request
Detaching view to another monitor can lead to wrong zoom level used for new shell vi-eclipse/Eclipse-Platform#239
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Feb 26, 2025 •
edited
Loading

Test Results

   505 files  ±0     505 suites  ±0   8m 21s ⏱️ -11s
 4 304 tests ±0   4 292 ✅ ±0   11 💤 ±0  1 ❌ ±0 
16 560 runs  ±0  16 453 ✅ ±0  106 💤 ±0  1 ❌ ±0 

For more details on these failures, see this check.

Results for commit 0ce9063. ± Comparison against base commit 7be6e97.

♻️ This comment has been updated with latest results.

@HeikoKlare HeikoKlare force-pushed the add-os-call-for-getdpiforwindows branch from 3cd5b9e to d7ef86a Compare March 6, 2025 20:47
@akurtakov
Copy link
Member

akurtakov commented Mar 6, 2025

Native rebuilds are failing due to issue with windows build machine it seems https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/5711

@HeikoKlare
Copy link
Contributor

HeikoKlare commented Mar 6, 2025

Native rebuilds are failing due to issue with windows build machine

Thank you for the info and for opening the help desk ticket!

@HeikoKlare HeikoKlare force-pushed the add-os-call-for-getdpiforwindows branch 4 times, most recently from 595b70d to bffcee1 Compare March 8, 2025 10:03
@akoch-yatta @HeikoKlare
[win32] add GetDpiForWindow OS call
0ce9063 
This commit adds the OS call for GetDpiForWindow.
@HeikoKlare HeikoKlare force-pushed the add-os-call-for-getdpiforwindows branch from bffcee1 to 0ce9063 Compare March 8, 2025 10:19
HeikoKlare
HeikoKlare approved these changes Mar 8, 2025
View reviewed changes
Copy link
Contributor

@HeikoKlare HeikoKlare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adapted to proper dynamic loading of the added method (since only available with Windows 10 1607 or newer). Verified asw orking on locally-built binaries adding to SWT Snippet1:

System.out.println(OS.GetDpiForWindow(shell.handle));

@HeikoKlare
Copy link
Contributor

HeikoKlare commented Mar 8, 2025

Failing test is unrelated and documented: #1843

@HeikoKlare HeikoKlare merged commit 7d4fba6 into eclipse-platform:master Mar 8, 2025
12 of 14 checks passed
@HeikoKlare HeikoKlare deleted the add-os-call-for-getdpiforwindows branch March 8, 2025 10:33
@HeikoKlare
Copy link
Contributor

HeikoKlare commented Mar 8, 2025

FTR: binaries successfully built and pushed: 9b1bcf4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HeikoKlare HeikoKlare HeikoKlare approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Detaching view to another monitor can lead to wrong zoom level used for new shell

3 participants

@akoch-yatta @akurtakov @HeikoKlare