-
Notifications
You must be signed in to change notification settings - Fork 186
Version bump for 4.36 stream #1876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I think it makes sense to immediately bump the minor version (instead of the micro version) since there will be according changes requiring a minor version bump during the release cycle anyway (as we already have PRs in the pipeline requiring it). |
Test Results 96 files ±0 96 suites ±0 5s ⏱️ +2s For more details on these errors, see this check. Results for commit bceac69. ± Comparison against base commit 7228a5c. ♻️ This comment has been updated with latest results. |
|
As far as I understand it now there is a cyclic problem unless the build succeeds new natives will not be pushed to git but until this happens I-build is unusable. What is the proposal to break this cycle? |
ad157fe to
a0f2f6b
Compare
|
What is the cause for the cyclic dependency? I would have expected that version bump + build script update should enable a successful build of SWT (including natives build and deployment). But the build does not find platform dependencies anymore: Should we just revert #1873 so that SWT is in a consistent state again and then do everything in proper order (first bump version, then update build script)? |
|
The issue seems to come from parent pom using 4.36 I-builds repo. This used to be done only after there is successful build in given stream so there is content in Ibuild repo. @MohananRahul why was it changed earlier this cycle? |
|
So this was caused by eclipse-platform/eclipse.platform.releng.aggregator#2799 . |
|
I'll switch the Ibuilds repo to 4.35 . It would be best if creation of new stream repo is filled initially with latest from previous stream. That should make it less fragile and allow more automation to kick in as there will be working version initially. |
Should allow to unbreak eclipse-platform/eclipse.platform.swt#1876
Should allow to unbreak eclipse-platform/eclipse.platform.swt#1876
Should allow to unbreak eclipse-platform/eclipse.platform.swt#1876
a0f2f6b to
bceac69
Compare
|
Sorry, I accidentally pushed again... |
|
Let's see what happens :) |
|
@HeikoKlare bumping minor made apitools complain Please either bump micro or add api filters. |
Update API filters to new version
bceac69 to
66f52e9
Compare
|
Jenkins build succeeds. Should we merge to have the natives built and puhsed, @akurtakov? |
|
Done. |
|
Thank you! Binaries are pushed: 6f2bd2d |
Also removes obsolete API filters for previous version