Skip to content

Conversation

@HeikoKlare
Copy link
Contributor

Also removes obsolete API filters for previous version

@HeikoKlare
Copy link
Contributor Author

I think it makes sense to immediately bump the minor version (instead of the micro version) since there will be according changes requiring a minor version bump during the release cycle anyway (as we already have PRs in the pipeline requiring it).

@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2025

Test Results

 96 files  ±0   96 suites  ±0   5s ⏱️ +2s
 58 tests ±0   19 ✅ ±0  0 💤 ±0  0 ❌ ±0  39 🔥 ±0 
191 runs  ±0  152 ✅ ±0  0 💤 ±0  0 ❌ ±0  39 🔥 ±0 

For more details on these errors, see this check.

Results for commit bceac69. ± Comparison against base commit 7228a5c.

♻️ This comment has been updated with latest results.

@akurtakov
Copy link
Member

As far as I understand it now there is a cyclic problem unless the build succeeds new natives will not be pushed to git but until this happens I-build is unusable. What is the proposal to break this cycle?

@HeikoKlare
Copy link
Contributor Author

What is the cause for the cyclic dependency? I would have expected that version bump + build script update should enable a successful build of SWT (including natives build and deployment). But the build does not find platform dependencies anymore:

Error:  Cannot resolve project dependencies:
Error:    You requested to install 'osgi.bundle; org.eclipse.core.runtime 0.0.0, max=2147483647' but it could not be found

Should we just revert #1873 so that SWT is in a consistent state again and then do everything in proper order (first bump version, then update build script)?

@akurtakov
Copy link
Member

The issue seems to come from parent pom using 4.36 I-builds repo. This used to be done only after there is successful build in given stream so there is content in Ibuild repo. @MohananRahul why was it changed earlier this cycle?

@akurtakov
Copy link
Member

So this was caused by eclipse-platform/eclipse.platform.releng.aggregator#2799 .

@akurtakov
Copy link
Member

I'll switch the Ibuilds repo to 4.35 . It would be best if creation of new stream repo is filled initially with latest from previous stream. That should make it less fragile and allow more automation to kick in as there will be working version initially.

akurtakov added a commit to akurtakov/eclipse.platform.releng.aggregator that referenced this pull request Mar 4, 2025
akurtakov added a commit to akurtakov/eclipse.platform.releng.aggregator that referenced this pull request Mar 4, 2025
akurtakov added a commit to eclipse-platform/eclipse.platform.releng.aggregator that referenced this pull request Mar 4, 2025
@HeikoKlare
Copy link
Contributor Author

Sorry, I accidentally pushed again...

@akurtakov
Copy link
Member

Let's see what happens :)

@akurtakov
Copy link
Member

@HeikoKlare bumping minor made apitools complain

Caused by: org.apache.maven.plugin.MojoFailureException: There are API errors:
16:07:37  META-INF/MANIFEST.MF:6 The minor version should be the same for version 3.130.0, since no new APIs have been added since version 3.129.0

Please either bump micro or add api filters.

Update API filters to new version
@HeikoKlare
Copy link
Contributor Author

Jenkins build succeeds. Should we merge to have the natives built and puhsed, @akurtakov?

@akurtakov akurtakov merged commit 6f2bd2d into eclipse-platform:master Mar 4, 2025
9 of 13 checks passed
@akurtakov
Copy link
Member

Done.

@HeikoKlare HeikoKlare deleted the versionbump-4.36 branch March 4, 2025 15:12
@HeikoKlare
Copy link
Contributor Author

Thank you! Binaries are pushed: 6f2bd2d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants