Extend ImageGcDrawer to support transparency #2073
Conversation
akoch-yatta
force-pushed
the
image-imagedata-scaling
branch
5 times, most recently
from
637e5cd to
42fc381
Compare
|
@fedejeanne Can you test this one on MacOS? With Snippet367 you should see the transparent drawing working or not. |
👍 I'll carve out some time later this week to test it on my Mac at home. |
akoch-yatta
force-pushed
the
image-imagedata-scaling
branch
from
42fc381 to
89dfb2b
Compare
This commit extends the usage of ImageGcDraware to support SWT.Transparency as style that will initialize each GC with a proper transparent bitmap.
akoch-yatta
force-pushed
the
image-imagedata-scaling
branch
from
89dfb2b to
86731b5
Compare
fedejeanne
force-pushed
the
image-imagedata-scaling
branch
3 times, most recently
from
5ae9c65 to
64388de
Compare
fedejeanne
left a comment
fedejeanne
left a comment
There was a problem hiding this comment.
I reviewed all implementations and also tested in Mac and Linux at home. I made some small modifications (reduced visibility of new methods) and also undid the change in line 701 of the Image class in linux in 64388de . The reason is that this change does not seem to belong in this PR and it may introduce undesired behavior. I also double-checked what we discussed in our call today and it is true that DPIUtil.getDeviceZoom() not always returns 100 on Linux, which is why I decided not to take any chances and I simply undid that change. If you still think that the change is necessary then please propose a follow-up PR and let us discuss the reason there.
This commit adapts the smooth scaling implementation to use ImageGcDrawer.
fedejeanne
force-pushed
the
image-imagedata-scaling
branch
from
64388de to
6b1f436
Compare
@akoch-yatta doing that let 2 tests fail in Linux so I had to revert back to |
|
The failing checks are due to infrastructure problems |
2 participants
This PR extends the usage of ImageGcDrawar to support SWT.Transparency as style that will initialize each GC with a proper transparent bitmap.
Important:
Adaption for GTK and Cocoa will be added when we agree on the approach
I can extract to DPIUtil change into a separate PR