[Gtk] Make Tree/Table cellDataProc safe for disposed items #2472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Table/Tree.remove method ends up firing Gtk signal(s) that cause cellDataProc to start. Make cellDataProc explicitly check whether item is disposed to prevent operating on disposed item. Fixes eclipse-platform#1606
Contributor
Member
Author
|
Merging as even if a "better" fix could be done, this kind of "safety" in signal handlers is nice to always have. |
laeubi
reviewed
Sep 1, 2025
bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Table.java
Show resolved
Hide resolved
akurtakov
added a commit
to akurtakov/eclipse.platform.swt
that referenced
this pull request
Sep 1, 2025
This was referenced Sep 1, 2025
akurtakov
added a commit
to akurtakov/eclipse.platform.swt
that referenced
this pull request
Sep 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Table/Tree.remove method ends up firing Gtk signal(s) that cause cellDataProc to start. Make cellDataProc explicitly check whether item is disposed to prevent operating on disposed item. Fixes #1606