Add drawImage API that takes only a destination rectangle

[arunjose696]

Introduces a new method that draws the full image into a specified destination rectangle without requiring source bounds. Consumers no longer need to call image.getBounds() to determine image dimensions, unlike the existing drawImage method (Image image, int srcX, int srcY, int srcWidth, int srcHeight, int destX, int destY, int destWidth, int destHeight), which required knowing the image size in advance.

[github-actions]

Test Results

  111 files   -  7    111 suites   - 7   12m 59s ⏱️ +59s
4 527 tests  - 54  4 511 ✅  - 51  14 💤  - 3  1 ❌  - 1  1 🔥 +1 
  274 runs   - 56    273 ✅  - 51   1 💤  - 3  0 ❌  - 2 

For more details on these failures and errors, see this check.

Results for commit 3e42bcc. ± Comparison against base commit f51bb3b.

This pull request removes 56 and adds 2 tests. Note that renamed tests count towards both.

AllWin32Tests ImageWin32Tests ‑ testDisposeDrawnImageBeforeRequestingTargetForOtherZoom
AllWin32Tests ImageWin32Tests ‑ testDrawImageAtDifferentZooms(boolean)[1] true
AllWin32Tests ImageWin32Tests ‑ testDrawImageAtDifferentZooms(boolean)[2] false
AllWin32Tests ImageWin32Tests ‑ testImageDataForDifferentFractionalZoomsShouldBeDifferent
AllWin32Tests ImageWin32Tests ‑ testImageShouldHaveDimesionAsPerZoomLevel
AllWin32Tests ImageWin32Tests ‑ testRetrieveImageDataAtDifferentZooms(boolean)[1] true
AllWin32Tests ImageWin32Tests ‑ testRetrieveImageDataAtDifferentZooms(boolean)[2] false
AllWin32Tests ImageWin32Tests ‑ test_getImageData_fromCopiedImage
AllWin32Tests ImageWin32Tests ‑ test_getImageData_fromImageForImageDataFromImage
AllWin32Tests TestTreeColumn ‑ test_ColumnOrder
…

org.eclipse.swt.tests.junit.Test_org_eclipse_swt_dnd_Clipboard ‑ Unknown test
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_graphics_GC ‑ test_drawImageLorg_eclipse_swt_graphics_ImageIIII

♻️ This comment has been updated with latest results.

[fedejeanne]

Initial review: please apply formatting in the affected code.

Question: why add a new API method, who needs it? Maybe in a follow-up PR?

[fedejeanne]

Question: why add a new API method, who needs it?

Answer to myself: it's in our internal issue (vi-eclipse/Eclipse-Platform#459)

A new API in GC is required to draw images at specified size. This is required for vi-eclipse/Eclipse-Platform#326 .

[fedejeanne]

Changes make sense.

Since there are no usages of this API, I can't test it and therefore I can't really approve it. I don't oppose it though 👍

[arunjose696]

Changes make sense.

Since there are no usages of this API, I can't test it and therefore I can't really approve it. I don't oppose it though 👍

I have now added a usage in the CTabFolder renderer. To test it, you can run an Eclipse runtime workspace:

• In open files, the unselected ones are drawn using the updated drawImage call in drawUnselected(). This now uses the new API, and you can verify that it has no visual impact on the image.
• The drawBackground method was also updated to use the new API, which made it possible to remove the getBounds() call.

For adapting the remaining usages I would be creating an issue

[fedejeanne]

Thank you for adding the usage, @arunjose696 . I see no visual defects on Windows when using this PR 👍

I haven't tested on Mac / Linux.

[arunjose696]

I have also added the tests for this new API similar to other drawImage() calls

[akoch-yatta]

Main purpose for this additional API is to get rid of any Image#getBounds calls in advance as this could result in creating unnecessary handles in windows. Additionally, most calls to this API are the exact use case of the new API: draw an Image scaled - so the original method should mainly be used to draw a dropped & scaled Image.

[akoch-yatta]

I tested on windows and shortly on GTK, both worked as expected to me. Reasons for the new API are mentioned.