Skip to content

Make test valid for backspace/delete #2549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2025
Merged

Make test valid for backspace/delete #2549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 15 additions & 22 deletions ...tests/JUnit Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_custom_StyledText.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
import static org.junit.Assert.fail;
import static org.junit.Assume.assumeFalse;

import java.time.Instant;
import java.util.ArrayList;
import java.util.Random;
import java.util.function.BooleanSupplier;
Expand Down Expand Up @@ -5856,38 +5855,32 @@ public void test_arrowDownKeepsPositionAfterNewLine() {
* Bug 565164 - SWT.BS event no longer working
*/
@Test
public void test_backspaceAndDelete() {
public void test_backspaceAndDelete() throws InterruptedException {
shell.open();
text.setSize(10, 50);
final Instant timeOut = Instant.now().plusSeconds(10);
// The display.post needs to successfully obtain the focused window (at least on GTK3)
// so we can send events to it. This processEvents gives SWT/GTK time to draw/focus/etc
// the window so that org.eclipse.swt.widgets.Display.findFocusedWindow()
// returns non-zero
SwtTestUtil.processEvents();

Display display = Display.getDefault();

Event a = keyEvent('a', SWT.KeyDown, display.getFocusControl());
Event aUp = keyEvent('a', SWT.KeyUp, display.getFocusControl());
Event backspace = keyEvent(SWT.BS, SWT.KeyDown, display.getFocusControl());
Event backspaceUp = keyEvent(SWT.BS, SWT.KeyUp, display.getFocusControl());

display.post(a);
display.post(aUp);
assertTrue(display.post(a));
assertTrue(display.post(aUp));

while (Instant.now().isBefore(timeOut)) {
if (text.getText().length() == 1) break;
SwtTestUtil.processEvents(10000, () -> text.getText().length() == 1);
assertEquals(1, text.getText().length());

if (!shell.isDisposed()) {
display.readAndDispatch();
}
}

// Simulate the backspace, ensuring that the caret is in the correct position
text.invokeAction(ST.DELETE_PREVIOUS);

while (Instant.now().isBefore(timeOut)) {
if (text.getText().length() == 0) break;

if (!shell.isDisposed()) {
display.readAndDispatch();
}
}
assertTrue(display.post(backspace));
assertTrue(display.post(backspaceUp));

SwtTestUtil.processEvents(10000, () -> text.getText().length() == 0);
assertEquals(0, text.getText().length());
}

Expand Down
36 changes: 13 additions & 23 deletions ....swt.tests/JUnit Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_widgets_Text.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@
import static org.junit.Assert.assertThrows;
import static org.junit.Assert.assertTrue;

import java.time.Instant;

import org.eclipse.swt.SWT;
import org.eclipse.swt.events.ModifyListener;
import org.eclipse.swt.events.SegmentListener;
Expand Down Expand Up @@ -1552,10 +1550,14 @@ private void doSegmentsTest (boolean isListening) {
* Bug 565164 - SWT.BS event no longer working
*/
@Test
public void test_backspaceAndDelete() {
public void test_backspaceAndDelete() throws InterruptedException {
shell.open();
text.setSize(10, 50);
final Instant timeOut = Instant.now().plusSeconds(10);
// The display.post needs to successfully obtain the focused window (at least on GTK3)
// so we can send events to it. This processEvents gives SWT/GTK time to draw/focus/etc
// the window so that org.eclipse.swt.widgets.Display.findFocusedWindow()
// returns non-zero
SwtTestUtil.processEvents();

Display display = Display.getDefault();

Expand All @@ -1564,28 +1566,16 @@ public void test_backspaceAndDelete() {
Event backspace = keyEvent(SWT.BS, SWT.KeyDown, display.getFocusControl());
Event backspaceUp = keyEvent(SWT.BS, SWT.KeyUp, display.getFocusControl());

display.post(a);
display.post(aUp);

while (Instant.now().isBefore(timeOut)) {
if (text.getText().length() == 1) break;

if (!shell.isDisposed()) {
display.readAndDispatch();
}
}

display.post(backspace);
display.post(backspaceUp);
assertTrue(display.post(a));
assertTrue(display.post(aUp));

while (Instant.now().isBefore(timeOut)) {
if (text.getText().length() == 0) break;
SwtTestUtil.processEvents(10000, () -> text.getText().length() == 1);
assertEquals(1, text.getText().length());

if (!shell.isDisposed()) {
display.readAndDispatch();
}
}
assertTrue(display.post(backspace));
assertTrue(display.post(backspaceUp));

SwtTestUtil.processEvents(10000, () -> text.getText().length() == 0);
assertEquals(0, text.getText().length());
}

Expand Down
Loading