[Win32] Remove superceded GC operations from history #2689
Conversation
|
@HeikoKlare Just to confirm: the current logic only removes a replaceable operation if it’s immediately preceding the new one. |
That would add another requirement to replaceable operations: they must be commutative. I don't know if that is currently the case and it's quite prone to errors as you have to thoroughly check that all such marker operations are completely independent (commutative). While we may be able to do that right now, I would be afraid that future changes could easily break that if developers are not properly aware of this requirement. Or we would need a whole bunch of tests to ensure it. So to conclude: the idea is definitely good, but I am not sure if it's worth the effort and, in particular, the risk coming along with it. |
The GC stores every operation changing the GC state to be able to repply it if a handle for a different zoom is requested. There are some operations which, if executing an operation of the same type subsequently, supercede each other. This, for example, applies to setting fonts, as when settings two fonts after each other, only the last one set is relevant. This change flags several GC operations as replaceable and implements the removal of previous operations from the operation history if a new operation is executed that supercedes the previous one. This slightly reduces the memory footprint.
akoch-yatta
force-pushed
the
gc-supercede-operations
branch
from
463d1a7 to
ff6e93a
Compare
3 participants
The GC stores every operation changing the GC state to be able to repply it if a handle for a different zoom is requested. There are some operations which, if executing an operation of the same type subsequently, supercede each other. This, for example, applies to setting fonts, as when settings two fonts after each other, only the last one set is relevant.
This change flags several GC operations as replaceable and implements the removal of previous operations from the operation history if a new operation is executed that supercedes the previous one. This slightly reduces the memory footprint.