Split the SWT workflow into a reusable part #2762
Conversation
Test Results 118 files 118 suites 17m 8s ⏱️ Results for commit b2b1b8a. ♻️ This comment has been updated with latest results. |
On its own this PR does not really change anything, but it is a building block to future PRs that will optimize the workflow. Part of eclipse-platform#2714
jonahgraham
force-pushed
the
split-workflow
branch
from
98a48e9 to
b2b1b8a
Compare
|
I believe this is uncontroversial so I am proceeding with it. |
|
@jonahgraham I think we now need to have one workflow call for the tests comment so one gets one comment / OS otherwhise the test report will become completely unusable. e.g assume the following
Now the test results on master (baseline) will be the mac tests and it gets compared to the state of Linux+Windows on the other PRs ... son one of them gets merged and you get a totally different baseline now... |
|
btw one can maybe get some inspiration form Equinox where we have some extra tests published form the TCK run: https://github.com/eclipse-equinox/equinox/blob/master/.github/workflows/unit-tests.yml But maybe for SWT consequently one should just have three workflows and three publisher workflows... |
As of this PR there is still only one workflow call - I assume you want these comments to apply to #2763 where we call the workflow many times? If you think the comment does apply here, I will revert this PR and we can start the review from scratch. See also #2764 (comment) |
Now worries, I just wanted to note it here but haven't seen your other PR |
2 participants
On its own this PR does not really change anything, but it is a building block to future PRs that will optimize the workflow.
Part of #2714