Quick fix for print exception of Snippet 292 #2784
Open
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fix results from the expected behaviour of the print in Snippet 292 to redraw the control to the GC by clicking the button. This occured as a subproblem in vi-eclipse/Eclipse-Platform#501 because this worked only once. The problem is that after the first click, the label points to the image, where the group printed itself into it via the GC. Clicking a second time, the image gets disposed. Hence, when the group wants to prints again, the label cannot print its image, as it was disposed. The quick fix for it is to force the label not pointing to the image, if it has one. The question why the label is invoked to print its image, whereby not being in the hierarchy of the control (the group) is likely to be connected to an undocumented flag "OS.PW_RENDERFULLCONTENT" in OS.printWindow() which leads back to eclipse-platform#373.
Contributor
Test Results 118 files ±0 118 suites ±0 15m 45s ⏱️ - 2m 30s Results for commit 672a1e4. ± Comparison against base commit 4241119. This pull request skips 1 test. |
| Image image = label.getImage (); | ||
| if (image != null) image.dispose (); | ||
| if (image != null) { | ||
| image.dispose (); |
Member
There was a problem hiding this comment.
Shouldn't the order be changed - first, set label image to null and afterwards dispose the image?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR results from the expected behavior of the print in Snippet 292 to redraw the control to the GC by clicking the button.
The problem is that after the first click, the label points to the image, where the group printed itself into it via the GC. Clicking a second time, the image gets disposed. Hence, when the group wants to prints again, the label cannot print its image, as it was disposed.
The quick fix for it is to force the label not pointing to the image, if it has one.
The question why the label is invoked to print its image, whereby not being in the hierarchy of the control (the group) is likely to be connected to an undocumented flag "OS.PW_RENDERFULLCONTENT" in OS.printWindow() which leads back to
#373.