Javadoc basher changes for 4.38 #2789
Open
+24
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@HeikoKlare But please dont close the task #2788, it is to be merged in RC2 only after verifying it. |
Contributor
Member
|
It looks like this PR does the opposite of what should be done. The deleted comment should instead be added in windows/mac javadoc too. |
Contributor
Author
|
Thanks for catching that! You’re absolutely right — I misunderstood the requirement and ended up doing the opposite of what was intended. |
deepika-u
force-pushed
the
4.38_javadoc_basher_changes
branch
2 times, most recently
from
8314654 to
cfda7a6
Compare
Contributor
Author
|
I’ve updated the PR as per your suggestion - the changes are added now in Windows and Mac. Please review and let me know if everything looks good now. |
deepika-u
force-pushed
the
4.38_javadoc_basher_changes
branch
from
cfda7a6 to
d0a0fee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SWT Javadoc bash for 4.38
Fixes #2788