Migrate JUnit 4 tests to JUnit 5 in org.eclipse.jface.text.tests #3410
+0
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 3 018 files 3 018 suites 2h 44m 53s ⏱️ For more details on these failures, see this check. Results for commit bd62671. ♻️ This comment has been updated with latest results. |
vogella
force-pushed
the
jface.text.tests_2
branch
from
5db2220 to
2c6cc72
Compare
vogella
added a commit
to vogella/eclipse.platform.ui
that referenced
this pull request
Oct 18, 2025
This commit fixes test failures introduced during the JUnit 5 migration in PR eclipse-platform#3410. Changes in FilteringAsyncContentAssistTests.java: - Changed import from org.junit.Ignore to org.junit.jupiter.api.Disabled - Replaced @ignore annotation with @disabled annotation and added reason message to properly skip the test - The test was failing because JUnit 5 does not recognize JUnit 4's @ignore annotation, causing a disabled test to run and fail Changes in ResourceInitialSelectionTest.java: - Migrated from JUnit 4 to JUnit 5 (file was missed in initial migration) - Updated imports: - org.junit.Assert → org.junit.jupiter.api.Assertions - org.junit.Before → org.junit.jupiter.api.BeforeEach - org.junit.After → org.junit.jupiter.api.AfterEach - Changed annotations: @before → @beforeeach, @after → @AfterEach - Fixed assertion parameter order for JUnit 5 (message parameter moved from first to last position) - All 13 tests now pass successfully Test Results: - FilteringAsyncContentAssistTests: 7 tests run, 0 failures, 1 properly skipped - ResourceInitialSelectionTest: 13 tests run, 0 failures, 0 errors 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
vogella
force-pushed
the
jface.text.tests_2
branch
from
45cc945 to
b1b1a29
Compare
vogella
added a commit
to vogella/eclipse.platform.ui
that referenced
this pull request
Oct 19, 2025
This commit fixes test failures introduced during the JUnit 5 migration in PR eclipse-platform#3410 for the org.eclipse.text.tests bundle. Changes: 1. Added missing JUnit 5 package import to MANIFEST.MF: - org.junit.jupiter.api.function (required for assertThrows) 2. Fixed assertEquals parameter order in TextEditTests.java: - JUnit 5 changed assertEquals signature from (message, expected, actual) to (expected, actual, message) - Fixed 61 assertions to use correct JUnit 5 parameter order 3. Fixed annotation in FindReplaceDocumentAdapterTest.java: - Changed @org.junit.Test (JUnit 4) to @test (JUnit 5) - This was preventing @beforeeach from running, causing null pointer errors All 578 tests now pass successfully (0 failures, 0 errors, 2 skipped). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
fedejeanne
reviewed
Oct 20, 2025
...t.tests/src/org/eclipse/jface/text/tests/contentassist/FilteringAsyncContentAssistTests.java
Show resolved
Hide resolved
fedejeanne
pushed a commit
to vogella/eclipse.platform.ui
that referenced
this pull request
Oct 20, 2025
This commit fixes test failures introduced during the JUnit 5 migration in PR eclipse-platform#3410 for the org.eclipse.text.tests bundle. Changes: 1. Added missing JUnit 5 package import to MANIFEST.MF: - org.junit.jupiter.api.function (required for assertThrows) 2. Fixed assertEquals parameter order in TextEditTests.java: - JUnit 5 changed assertEquals signature from (message, expected, actual) to (expected, actual, message) - Fixed 61 assertions to use correct JUnit 5 parameter order 3. Fixed annotation in FindReplaceDocumentAdapterTest.java: - Changed @org.junit.Test (JUnit 4) to @test (JUnit 5) - This was preventing @beforeeach from running, causing null pointer errors All 578 tests now pass successfully (0 failures, 0 errors, 2 skipped). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
fedejeanne
force-pushed
the
jface.text.tests_2
branch
from
b434f67 to
b8e017d
Compare
|
Yes, I fixed some non-running tests to add the range. But now the JDT's junit runner also has ranges so not entirely clearly what is needed where. I though it would be good to mention it... |
vogella
added a commit
to vogella/eclipse.platform.ui
that referenced
this pull request
Oct 20, 2025
This commit fixes test failures introduced during the JUnit 5 migration in PR eclipse-platform#3410 for the org.eclipse.text.tests bundle. Changes: 1. Added missing JUnit 5 package import to MANIFEST.MF: - org.junit.jupiter.api.function (required for assertThrows) 2. Fixed assertEquals parameter order in TextEditTests.java: - JUnit 5 changed assertEquals signature from (message, expected, actual) to (expected, actual, message) - Fixed 61 assertions to use correct JUnit 5 parameter order 3. Fixed annotation in FindReplaceDocumentAdapterTest.java: - Changed @org.junit.Test (JUnit 4) to @test (JUnit 5) - This was preventing @beforeeach from running, causing null pointer errors All 578 tests now pass successfully (0 failures, 0 errors, 2 skipped). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
vogella
force-pushed
the
jface.text.tests_2
branch
3 times, most recently
from
75794ca to
4a39f29
Compare
|
Update this PR to only include changes for org.eclipse.jface.text.tests |
|
No idea what this error message means: Tests run: 32, Failures: 0, Errors: 0, Skipped: 0 CoreSVG has logged an error. Set environment variabe "CORESVG_VERBOSE" to learn more. |
vogella
force-pushed
the
jface.text.tests_2
branch
from
4a39f29 to
bd62671
Compare
Use Claude code to implement fixes for both old issues, the fixes look good to me. |
vogella
force-pushed
the
jface.text.tests_2
branch
from
bd62671 to
40763b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.