Skip to content

Add constant for riscv64 architecture in Platform class #1575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Add constant for riscv64 architecture in Platform class #1575

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion runtime/bundles/org.eclipse.core.runtime/META-INF/MANIFEST.MF
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: %pluginName
Bundle-Version: 3.31.100.qualifier
Bundle-Version: 3.32.0.qualifier
Bundle-SymbolicName: org.eclipse.core.runtime; singleton:=true
Bundle-Vendor: %providerName
Bundle-Activator: org.eclipse.core.internal.runtime.PlatformActivator
Expand Down
9 changes: 9 additions & 0 deletions runtime/bundles/org.eclipse.core.runtime/src/org/eclipse/core/runtime/Platform.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,6 +409,15 @@ public static boolean isMac() {
*/
public static final String ARCH_AARCH64 = "aarch64";//$NON-NLS-1$

/**
* Constant string (value {@code aarch64} indicating the platform is running on
Copy link
Member Author

@HannesWell HannesWell Oct 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The value of course should have been riscv64. This is fixed in

* an RISC-V 64bit-based architecture.
*
* @since 3.32
*
*/
public static final String ARCH_RISCV64 = "riscv64";//$NON-NLS-1$

/**
* Constant string (value "amd64") indicating the platform is running on an
* AMD64-based architecture.
Expand Down
Loading