Skip to content

Conversation

@laeubi
Copy link
Contributor

@laeubi laeubi commented Jun 17, 2025

Migrated from
https://github.com/eclipse-cdt/cdt/tree/main/terminal/plugins/org.eclipse.tm.terminal.view.core Commit 9b6fded373b3518ebfa6abe307d5ee6673f30c33

@laeubi
Copy link
Contributor Author

laeubi commented Jun 17, 2025

@jonahgraham I plan to merge this once the build is green if there are no objections.

@merks
Copy link
Contributor

merks commented Jun 17, 2025

This sounds like a good plan.

Have you applied all the formatting and cleanups?

@laeubi
Copy link
Contributor Author

laeubi commented Jun 17, 2025

Have you applied all the formatting and cleanups?

I have added minimal fixups to make the build happy, just in case someone wants to compare this with the CDT state. Once the migration is done I plan to add the terminal folder to the usual cleanup actions and then let the cleanup be performed on top of it.

@github-actions
Copy link
Contributor

Test Results

 1 893 files  ±0   1 893 suites  ±0   1h 29m 4s ⏱️ - 8m 4s
 4 381 tests ±0   4 357 ✅ ±0   24 💤 ±0  0 ❌ ±0 
13 143 runs  ±0  12 976 ✅ ±0  167 💤 ±0  0 ❌ ±0 

Results for commit 2c611cc. ± Comparison against base commit e152801.

@laeubi laeubi merged commit bfe67d8 into eclipse-platform:master Jun 17, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants