Rename eclipse.tm.terminal > eclipse.terminal

[laeubi]

FYI @merks @akurtakov @jonahgraham

[github-actions]

Test Results

 1 947 files  ±0   1 947 suites  ±0   1h 29m 10s ⏱️ - 2m 21s
 4 717 tests ±0   4 693 ✅ ±0   24 💤 ±0  0 ❌ ±0 
14 151 runs  ±0  13 984 ✅ ±0  167 💤 ±0  0 ❌ ±0 

Results for commit 65ed9ea. ± Comparison against base commit 731e745.

This pull request removes 336 and adds 336 tests. Note that renamed tests count towards both.

org.eclipse.tm.internal.terminal.connector.TerminalConnectorFactoryTest ‑ testConnect
org.eclipse.tm.internal.terminal.connector.TerminalConnectorFactoryTest ‑ testDisconnect
org.eclipse.tm.internal.terminal.connector.TerminalConnectorFactoryTest ‑ testGetAdapter
org.eclipse.tm.internal.terminal.connector.TerminalConnectorFactoryTest ‑ testGetIdAndName
org.eclipse.tm.internal.terminal.connector.TerminalConnectorFactoryTest ‑ testGetInitializationErrorMessage
org.eclipse.tm.internal.terminal.connector.TerminalConnectorFactoryTest ‑ testGetSettingsSummary
org.eclipse.tm.internal.terminal.connector.TerminalConnectorFactoryTest ‑ testGetTerminalToRemoteStream
org.eclipse.tm.internal.terminal.connector.TerminalConnectorFactoryTest ‑ testIsInitialized
org.eclipse.tm.internal.terminal.connector.TerminalConnectorFactoryTest ‑ testIsLocalEcho
org.eclipse.tm.internal.terminal.connector.TerminalConnectorFactoryTest ‑ testLoad
…

org.eclipse.terminal.internal.connector.TerminalConnectorFactoryTest ‑ testConnect
org.eclipse.terminal.internal.connector.TerminalConnectorFactoryTest ‑ testDisconnect
org.eclipse.terminal.internal.connector.TerminalConnectorFactoryTest ‑ testGetAdapter
org.eclipse.terminal.internal.connector.TerminalConnectorFactoryTest ‑ testGetIdAndName
org.eclipse.terminal.internal.connector.TerminalConnectorFactoryTest ‑ testGetInitializationErrorMessage
org.eclipse.terminal.internal.connector.TerminalConnectorFactoryTest ‑ testGetSettingsSummary
org.eclipse.terminal.internal.connector.TerminalConnectorFactoryTest ‑ testGetTerminalToRemoteStream
org.eclipse.terminal.internal.connector.TerminalConnectorFactoryTest ‑ testIsInitialized
org.eclipse.terminal.internal.connector.TerminalConnectorFactoryTest ‑ testIsLocalEcho
org.eclipse.terminal.internal.connector.TerminalConnectorFactoryTest ‑ testLoad
…

♻️ This comment has been updated with latest results.

[jonahgraham]

Note that the before naming of these packages isn't great - but many of these packages with "internal" in their name are API (no x-internal tag). This means that consumers of this API now have to adapt.

For example in other parts of CDT we use these packages.

These packages were explicitly API, see for example eclipse-cdt/cdt@3d2cdcc

Therefore, I don't think we can rename these packages without even more coordination with CDT (and possibly other clients - but honestly I don't know if there are any)

[jonahgraham]

PS If I said something earlier that implied approving of this change then I apologize for my confusion over what was being renamed. I am ok to rename the features, and I would be ok to rename the bundles/packages in alignment with other projects (mostly CDT)

[laeubi]

@jonahgraham yes consumers need to adapt when migrating to the new namespace, I also think we should make things that are not really "internal" should be made proper API now. I Plan to do that for the provisional.api packages as a next step.