Skip to content

Conversation

@AlexanderLanin
Copy link
Member

No description provided.

Co-authored-by: Maximilian Sören Pollak <MaximilianSoerenPollak@users.noreply.github.com>
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates from a complex multi-target documentation system to a simplified docs-as-code approach with standardized target names at the root level. The changes move away from package-specific docs targets to root-level targets with consistent naming conventions.

Key changes:

  • Consolidates documentation targets from //docs:* to //:* naming pattern
  • Simplifies the build system by removing complex multi-target configurations
  • Updates external dependencies references to use the new + naming convention instead of ~

Reviewed Changes

Copilot reviewed 25 out of 25 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/tests/test_consumer.py Updates test commands to use simplified root-level targets
src/tests/README.md Updates documentation to reference new target paths
src/requirements.txt Changes external dependency references from ~ to + format
src/incremental.py Simplifies build configuration and removes unused environment variables
docs.bzl Major refactoring from complex multi-target system to simplified single-target approach
BUILD Moves documentation targets to root level and adds process dependency
Multiple config files Updates references to new target naming conventions
Comments suppressed due to low confidence (1)

src/extensions/score_metamodel/tests/test_external_needs.py:42

  • The test function test_parser is empty and provides no test coverage. Either implement the test or remove it if it's not needed.
def test_parser():

@github-actions
Copy link

github-actions bot commented Jul 29, 2025

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //src:license-check

Status: ✅ Passed

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: 8e592398-a336-4d09-bd31-b834d7a791ac
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: src
Analyzing: target //src:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //src:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //src:license-check (69 packages loaded, 9 targets configured)

Analyzing: target //src:license-check (115 packages loaded, 1132 targets configured)

Analyzing: target //src:license-check (121 packages loaded, 2363 targets configured)

Analyzing: target //src:license-check (126 packages loaded, 2412 targets configured)

INFO: Analyzed target //src:license-check (129 packages loaded, 4428 targets configured).
[9 / 13] Creating runfiles tree bazel-out/k8-opt-exec-ST-d57f47055a04/bin/external/score_dash_license_checker+/tool/formatters/dash_format_converter.runfiles [for tool]; 0s local ... (2 actions, 1 running)
INFO: Found 1 target...
Target //src:license.check.license_check up-to-date:
  bazel-bin/src/license.check.license_check
  bazel-bin/src/license.check.license_check.jar
INFO: Elapsed time: 13.550s, Critical Path: 0.77s
INFO: 13 processes: 3 disk cache hit, 9 internal, 1 processwrapper-sandbox.
INFO: Build completed successfully, 13 total actions
INFO: Running command line: bazel-bin/src/license.check.license_check src/formatted.txt <args omitted>
[main] INFO Querying Eclipse Foundation for license data for 84 items.
[main] INFO Found 58 items.
[main] INFO Querying ClearlyDefined for license data for 26 items.
[main] INFO Found 26 items.
[main] INFO Vetted license information was found for all content. No further investigation is required.

_ = parse_external_needs_sources_from_DATA('["@not_a_valid_string"]')


def test_parser(): ...
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

# https://www.sphinx-doc.org/en/master/usage/configuration.html#project-information

project = "Score Docs-as-Code"
project_url = "https://eclipse-score.github.io/docs-as-code/"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MaximilianSoerenPollak MaximilianSoerenPollak merged commit f99699c into main Jul 30, 2025
4 of 7 checks passed
@MaximilianSoerenPollak MaximilianSoerenPollak deleted the update branch July 30, 2025 08:37
@github-project-automation github-project-automation bot moved this from Draft to Done in Infrastructure Jul 30, 2025
@MaximilianSoerenPollak
Copy link
Contributor

Note:
This PR was merged red due to major breaking changes.
Therefore the dependencies (that also depend on docs-as-code) do not reflect the new 1.0.0 changes yet and can not be used to build / consumer-test correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants