Fix flaky test

[a-zw]

📌 Description

Enables a test previously marked as flaky and makes it stable.

Closes #226

🚨 Impact Analysis

• This change does not violate any tool requirements and is covered by existing tool requirements
• This change does not violate any design decisions

[github-actions]

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //src:license-check

Status: ⚠️ Needs Review

Click to expand output

[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: 67909986-2998-4ed9-a4eb-2be6f02f225f
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: src
Analyzing: target //src:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //src:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //src:license-check (66 packages loaded, 9 targets configured)

Analyzing: target //src:license-check (73 packages loaded, 9 targets configured)

Analyzing: target //src:license-check (123 packages loaded, 2209 targets configured)

Analyzing: target //src:license-check (134 packages loaded, 2484 targets configured)

Analyzing: target //src:license-check (137 packages loaded, 4498 targets configured)

INFO: Analyzed target //src:license-check (137 packages loaded, 4500 targets configured).
INFO: Found 1 target...
Target //src:license.check.license_check up-to-date:
  bazel-bin/src/license.check.license_check
  bazel-bin/src/license.check.license_check.jar
INFO: Elapsed time: 15.513s, Critical Path: 0.43s
INFO: 13 processes: 4 disk cache hit, 9 internal.
INFO: Build completed successfully, 13 total actions
INFO: Running command line: bazel-bin/src/license.check.license_check src/formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

[github-actions]

The created documentation from the pull request is available at: docu-html

[AlexanderLanin]

• you have multiple authors here, do you want to keep it or squash and force push this change?
• could you shortly explain why it was unstable

[AlexanderLanin]

@dcalavrezo-qorix careful, some workflows did not run yet.

pull_request requires manual approval. pull_request_target is executed immediately.

[a-zw]

Why was it flaky? I'm not sure.

The asserts are weird. Apparently, the order in strings ("foo, bar" and "bar, foo") was not considered deterministic, so the string was converted into a set of characters for comparison which is rather impossible to debug. The order seems actually deterministic.

It isn't even clear to me what we are testing here, so we might as well delete the test...

[AlexanderLanin]

I guess we merge the fix for now, and revisit the test when we really look at verification.