Skip to content

Conversation

@pawelrutkaq
Copy link
Contributor

Add specific SDP build file for aarach64
to correct paths

extensions.bzl Outdated
if sdp.arch == "aarch64":
build_file = "@score_toolchains_qnx//toolchains:sdp_aarch64.BUILD"
else:
build_file = "@score_toolchains_linux//toolchains:sdp.BUILD"
Copy link

@evinoth1206 evinoth1206 Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is it refering to toolchains_linux?

shouldn't be like: build_file = "@score_toolchains_qnx//toolchains:sdp.BUILD"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, reworked

@pawelrutkaq pawelrutkaq force-pushed the pawelrutkaq_fix_aarach64_setup branch from d8bac4a to b1aad52 Compare November 14, 2025 16:27
@pawelrutkaq
Copy link
Contributor Author

@nradakovic can you look into, shall now have open interface. seems to not be other way to support some build ins and customs (i dont want each score module needs to set build file manually)

@pawelrutkaq pawelrutkaq force-pushed the pawelrutkaq_fix_aarach64_setup branch from b1aad52 to bc5e54e Compare November 17, 2025 06:56
@pawelrutkaq
Copy link
Contributor Author

pawelrutkaq commented Nov 17, 2025

I dropped build_file support. It appeared (test on other modules) that the extensions does not have an access to modules defined outside them. So you cannot pass any label from calling module.Unless someone knows a solution to this problem, I have integrated just aarch64 support. Currently I see no other ways for others to maintain forked repo and having own additions there.

@pawelrutkaq pawelrutkaq force-pushed the pawelrutkaq_fix_aarach64_setup branch from bc5e54e to fab3138 Compare November 17, 2025 10:34
@pawelrutkaq pawelrutkaq force-pushed the pawelrutkaq_fix_aarach64_setup branch from fab3138 to 1fd9e57 Compare November 17, 2025 10:36
@pawelrutkaq pawelrutkaq force-pushed the pawelrutkaq_fix_aarach64_setup branch from 1fd9e57 to 9821020 Compare November 17, 2025 10:38
Add specific SDP build file for aarach64
to correct paths
target = "@%{toolchain_sdp}//:target_all",
)

qnx_fs_toolchain_config(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these are common, or?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just splited it in case one of attr would differe later.

@FScholPer
Copy link
Contributor

@AlexanderLanin Can we added the secret to the environment?

@AlexanderLanin
Copy link
Member

@AlexanderLanin Can we added the secret to the environment?

I'll sync with Anton what is going on with the qnx license.

@AlexanderLanin AlexanderLanin added this pull request to the merge queue Nov 20, 2025
Merged via the queue into eclipse-score:main with commit 14edb9d Nov 20, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants