-
Notifications
You must be signed in to change notification settings - Fork 7
aarch64 QNX toolchain fixes #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aarch64 QNX toolchain fixes #27
Conversation
extensions.bzl
Outdated
| if sdp.arch == "aarch64": | ||
| build_file = "@score_toolchains_qnx//toolchains:sdp_aarch64.BUILD" | ||
| else: | ||
| build_file = "@score_toolchains_linux//toolchains:sdp.BUILD" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is it refering to toolchains_linux?
shouldn't be like: build_file = "@score_toolchains_qnx//toolchains:sdp.BUILD"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, reworked
d8bac4a to
b1aad52
Compare
|
@nradakovic can you look into, shall now have open interface. seems to not be other way to support some build ins and customs (i dont want each score module needs to set build file manually) |
b1aad52 to
bc5e54e
Compare
|
I dropped build_file support. It appeared (test on other modules) that the extensions does not have an access to modules defined outside them. So you cannot pass any |
bc5e54e to
fab3138
Compare
fab3138 to
1fd9e57
Compare
1fd9e57 to
9821020
Compare
Add specific SDP build file for aarach64 to correct paths
9821020 to
faba4d6
Compare
| target = "@%{toolchain_sdp}//:target_all", | ||
| ) | ||
|
|
||
| qnx_fs_toolchain_config( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these are common, or?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just splited it in case one of attr would differe later.
|
@AlexanderLanin Can we added the secret to the environment? |
I'll sync with Anton what is going on with the qnx license. |
Add specific SDP build file for aarach64
to correct paths