MX Bean support #43
Merged
MX Bean support #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatrickTasse
requested changes
Feb 10, 2025
README.md
Outdated
| | Instrumentation | 72 ns | | ||
| | AsyncFileHandler | 1100 ns | | ||
| | FileHandler | 45000 ns | | ||
| | Beans Enabled AsyncFileHandler | 1400 ns | |
Contributor
There was a problem hiding this comment.
Should this be Beans-Enabled?
Could align the column size for other rows?
Contributor
Author
There was a problem hiding this comment.
asyncfilehandler adds latencies too.
src/main/java/org/eclipse/tracecompass/traceeventlogger/beans/ITraceEventLoggerBean.java
Outdated
Show resolved
Hide resolved
src/main/java/org/eclipse/tracecompass/traceeventlogger/beans/TraceEventLoggerManager.java
Outdated
Show resolved
Hide resolved
src/main/java/org/eclipse/tracecompass/traceeventlogger/beans/ITraceEventLoggerBean.java
Outdated
Show resolved
Hide resolved
src/main/java/org/eclipse/tracecompass/traceeventlogger/beans/ITraceEventLoggerBean.java
Outdated
Show resolved
Hide resolved
src/main/java/org/eclipse/tracecompass/traceeventlogger/beans/ITraceEventLoggerBean.java
Outdated
Show resolved
Hide resolved
| /** | ||
| * Get the observed element name | ||
| * | ||
| * @return the observed element names (in the order of being added) |
Contributor
There was a problem hiding this comment.
name, or are there many names returned (in which case, what is the delimiter?)
Contributor
Author
There was a problem hiding this comment.
You got a point, I was talking about the full way of working. But every bean holds one value.
src/main/java/org/eclipse/tracecompass/traceeventlogger/beans/TraceEventLoggerBean.java
Outdated
Show resolved
Hide resolved
Brings monitoring support to the trace event logger. Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
MatthewKhouzam
force-pushed
the
frijoles
branch
from
d38446f to
4de9869
Compare
PatrickTasse
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Add MX Bean support to the trace event logger
How to test
Run with
-DenableMonitoring=trueand attach jconsole to it.In VisualVM:
Follow-ups
Review checklist