Use system timestamp since the unix epoch #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kavehshahedi
force-pushed
the
timestamp-offset
branch
2 times, most recently
from
e5f4b57 to
def3fbd
Compare
Previously, we used System.nanoTime() to capture system's timestamp in nanoseconds, which works fine. However, since this method returns the timestamp since the machine's boot, it might not be precise for aligning the trace time with the current actual time. We now capture the offset of System.nanoTime() with the actual system's time, and after that, every captured timestamp will sum-up with the offset. Signed-off-by: Kaveh Shahedi <kaveh.shahedi@ericsson.com>
kavehshahedi
force-pushed
the
timestamp-offset
branch
from
def3fbd to
011e239
Compare
MatthewKhouzam
approved these changes
Feb 19, 2025
PatrickTasse
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Previously, we used
System.nanoTime()to capture the system's timestamp in nanoseconds, which works fine. However, since this method returns the timestamp since the machine's boot, it might not be precise enough to align the trace time with the current actual time. We now capture the offset ofSystem.nanoTime()with the actual system's time, and after that, every captured timestamp will sum up with the offset.How to test
Just use the ordinary tracing method in your project. From now on, you can see the timestamps are aligned with the system's actual time.
Follow-ups
N/A
Review checklist