added dynamic install of rust toolchain based on host arch and OS #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xerner
force-pushed
the
added-dynamic-rust-toolchain-installation
branch
from
dfd0efd to
dd27240
Compare
Contributor
AnotherDaniel
left a comment
AnotherDaniel
left a comment
There was a problem hiding this comment.
Good stuff, thank you!
I've added one thought wrt the MacOS workaround that I've originally added...
.devcontainer/scripts/post-create.sh
Outdated
|
|
||
| #region sudo stuff | ||
|
|
||
| # This is a workaround which is againt necessary on MacOS 14.0, it looks like this bug is back: |
Contributor
There was a problem hiding this comment.
I haven't looked into details at all, and didn't test-run this myself, yet, but: if we now know our $ARCH_AND_OS, might it make sense to only run this workaround section when on MacOS? Could that be done? ...
I'll be able to actually test maybe later today, latest early next week.
Contributor
Author
There was a problem hiding this comment.
I updated the script and wrapped the Mac workaround stuff with what I think is a Mac OS check (based on google searching)
AnotherDaniel
approved these changes
Aug 4, 2025
Contributor
AnotherDaniel
left a comment
AnotherDaniel
left a comment
There was a problem hiding this comment.
Tested on my Machine (Mac), looking good!
AnotherDaniel
added a commit
to eclipse-uprotocol/up-subscription-rust
that referenced
this pull request
Aug 15, 2025
…ty (#30) Dynamic install of rust toolchain based on host arch and OS (as has been done in eclipse-uprotocol/up-rust#275) * dynamic install of rust toolchain based on host arch and OS * wrap mac workaround script in OS check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous installation of the rust toolchain was done inside the
Dockerfile. Docker has no knowledge of the host architecture and OS while it is building containers. Therefore, I moved the installation outside of theDockerfileand into the a bash function that is called in thepost-create.shscript.If using the Dev Containers extension in VS Code, the
post-create.shscript is ran immediately after the container is created by VS Code, and installs the rust toolchain for your current hosts architecture and OS. It also adds the architecture and OS as a rust build targetFor example, I am running WSL with an x86-64 architecture so it performed the following actions immediately after the Docker container built
rustup target add x86_64-unknown-linux-gnurustup toolchain install stable-x86_64-unknown-linux-gnuI believe this is further proof the install succeeded as I was able to run all unit tests for this repo
